Angle bracket <BuiltIn /> components #681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: for the time being, the canonical URL for the API documentation is https://emberjs.com/api/ember/release/classes/Ember.Templates.helpers/methods/link-to?anchor=link-to. We would probably want to change this, but there is a chicken and egg problem, so please leave those URLs as-is for now. |
jamescdavis
suggested changes
Mar 20, 2019
Co-Authored-By: chancancode <godfreykfc@gmail.com>
Co-Authored-By: chancancode <godfreykfc@gmail.com>
Co-Authored-By: chancancode <godfreykfc@gmail.com>
acorncom
approved these changes
Mar 21, 2019
|
Thanks @chancancode |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per RFC #459, we need to update the Octane guides to use
<AngleBracket />invocation syntax for the built-in components:<Input />,<Textarea />and<LinkTo />.The feature has landed (behind a feature flag) in ember.js in emberjs/ember.js#17735 (
<Input />,<Textarea />) and emberjs/ember.js#17772 (<LinkTo />). The API docs have not been updated yet, but the RFC text and the tests should be a good enough reference for the time being.In this PR, I started the work by converting the main
<LinkTo />guide, which is probably the trickiest. I preserved the flow of the guide but updated the content to fit the new API whenever it makes sense.I would like to hand of this work to other editors, but I'm happy to answer any questions or help review related PRs.