Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add metadata option for .visit #75

Merged
merged 3 commits into from
Oct 27, 2016
Merged

Add metadata option for .visit #75

merged 3 commits into from
Oct 27, 2016

Conversation

thoov
Copy link
Contributor

@thoov thoov commented Aug 1, 2016

Allows an option of metadata to be passed into options like:

fastboot.visit('...', { metadata: { foo: 'bar' } });

This enables per request information to be passed into the app such as user session info.

Related service change: ember-fastboot/ember-cli-fastboot#245

Allows an option of metaData to be passed into options like:
  fastboot.visit('', { metaData: { foo: 'bar' } });

This enables per request information to be passed into the app such
as user session info.
@thoov thoov changed the title Add metaData option for .visit Add metadata option for .visit Aug 1, 2016
@jasonmit
Copy link
Contributor

jasonmit commented Aug 2, 2016

@danmcclain @tomdale this is based on what we discussed last week on Slack.

We have an application that builds up state before the fastboot-middleware handles the request. So rather than rebuilding that state up within the fastboot app, we would like the ability to provide that to the application instance.

We currently do this and think it may be beneficial for future travelers as well to have the option.

@kellyselden
Copy link
Member

I just became blocked on this.

@rwjblue rwjblue merged commit c2e9fd4 into ember-fastboot:master Oct 27, 2016
@thoov thoov deleted the metadata branch October 27, 2016 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants