Use latest visit API #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
| this.waitForBoot = function() { | ||
| return appBoot.promise; | ||
| }; | ||
| var AppFactory = sandbox.require('~fast-boot/app-factory'); |
There was a problem hiding this comment.
Pardon my ignorance, but what does ~ do here?
There was a problem hiding this comment.
I copied it from Stef :P I think it is just to make it less likely to collide with user codez; on the other hand, I already relied on a globa called FastBoot so...
There was a problem hiding this comment.
This is injected from the addon build step
chancancode
force-pushed
the
new-visit-api
branch
3 times, most recently
from
7a5b606
to
2c71bde
Compare
This commit has an implicit cross-dependency on ember-fastboot/ember-cli-fastboot#71. This commit takes advantage of the new visit API in Ember and moves most of the heavy-lifting (runtime stuff) into the server.
chancancode
force-pushed
the
new-visit-api
branch
from
2c71bde
to
6ae5e6e
Compare
|
LGTM @tomdale - Can you review? |
| var sandbox = createSandbox(appBoot.resolve, { | ||
| najax: najax | ||
| }); | ||
| var sandbox = createSandbox({ najax: najax }); |
There was a problem hiding this comment.
We should think about exposing a more flexible primitive for this so addons can do similar things.
|
Awesome work, @chancancode! |
|
Published this as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update fastboot server for emberjs/ember.js#12394
Require coordination from ember-fastboot/ember-cli-fastboot#71
autoBootFastBootglobalOpen question:
cc @tomdale @stefanpenner