Ensure rehydration works on Ember < 3.27 #862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The fallback for the guard introduced in 32d6f07 (which takes effect when running on Ember < 3.27) is somewhat fundamentally borked. Due to the usage of `var Ember` and the fact that `var` hoists, the fallback in the ternary **can never** anything but `undefined`.
|
This likely fixes the thing that @snewcomer mentioned in #849 (comment) (when I was debugging with @scalvert it present in the same way that Scott mentioned). |
|
@rwjblue I just ran into this whilst trying to use Fastboot beta 4 with a Ember 3.24.x app. Can you look at doing a beta release sooner than later? Edit: looks like beta 5 is out now 🤙🏾 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fallback for the guard introduced in 32d6f07 (which takes effect when running on Ember < 3.27) is somewhat fundamentally borked. Due to the usage of
var Emberand the fact thatvarhoists, the fallback in the ternary can never anything butundefined.