Adding github action tests

[kiwiupover]

Adding github action tests

• mocha tests against node 12, 10
• ember tests
• windows mocha test against node 12, 10
• window ember tests

This is my github brach running these test. https://github.com/kiwiupover/ember-cli-fastboot/runs/883210806

The mocha window tests are having a hard time.
@rwjblue

[rwjblue]

😭

[rwjblue]

I find it vaguely odd to use npm here. Can you swap to yarn?

[rwjblue]

Should be running yarn not npm install.

See config in .travis.yml:

ember-cli-fastboot/.travis.yml

Line 34 in 19f0c67

- yarn --ignore-engines

[rwjblue]

Since nothing is special/different about these mocha tests from the test-mocha job, we should consolidate them to a single job configuration above. I made an inline suggestion for that...

[rwjblue]

We can avoid duplicate job definitions by using a matrix for OS also:

Suggested change

	test-mocha:
	name: Mocha Tests
	runs-on: ubuntu-latest
	strategy:
	matrix:
	node-version: [12.x, 10.x]
	test-mocha:
	name: "Mocha - ${{ matrix.node-version }} - ${{ matrix.os }}"
	runs-on: "${{ matrix.os }}-latest"
	strategy:
	matrix:
	node-version: [12.x, 10.x]
	os: [ubuntu, windows]

[rwjblue]

Shouldn't need to do this.

[rwjblue]

Should be able to consolidate these in the job above with a matrix.os.

[rwjblue]

FWIW, I think this is automatically set now

[kiwiupover]

@rwjblue I have kept mocha tests split between Ubuntu and Windows because I can't get the Windows tests to pass on Github actions. I have combined the ember test into a matrix of os and node versions.