Add support for custom configuration #752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kratiahuja
requested changes
Mar 3, 2020
index.js
Outdated
| @@ -79,6 +79,8 @@ module.exports = { | |||
| this._appRegistry = app.registry; | |||
| this._name = app.name; | |||
|
|
|||
| this.options = this._optionsFor(app.env, app.project); | |||
There was a problem hiding this comment.
Nitpick: Maybe better to name this this.fastbootOptions for clarity.
bobisjan
force-pushed
the
fastboot-config
branch
3 times, most recently
from
a087a27
to
886f9ab
Compare
bobisjan
force-pushed
the
fastboot-config
branch
2 times, most recently
from
c84f169
to
0ecc1da
Compare
kratiahuja
approved these changes
Mar 8, 2020
bobisjan
force-pushed
the
fastboot-config
branch
from
0ecc1da
to
355a358
Compare
Done ✅, the section uses option and link for |
kratiahuja
reviewed
Mar 8, 2020
bobisjan
force-pushed
the
fastboot-config
branch
from
355a358
to
ad4690f
Compare
|
This is good to go IMO after the minor update to readme about |
bobisjan
force-pushed
the
fastboot-config
branch
from
ad4690f
to
40b6634
Compare
|
Thanks for addressing the comments. Merging this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for reading FastBoot configuration from
config/fastboot.js(similar to how other add-ons likeember-intlworks).It should be possible to share this file with production server
fastboot-app-server.TODOs
README.md