Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix custom app build issue #730 #737

Merged

Conversation

dnalagatla
Copy link
Contributor

@dnalagatla dnalagatla commented Oct 29, 2019

Fixed issue #730
Revert "cheerio is used outside of tests so must be a dependency not a"

This reverts commit 097ad83.

Revert "Added support to update manifest app files from index.html"

This reverts commit 0a12a6f.

@rwjblue @kratiahuja

Revert "cheerio is used outside of tests so must be a dependency not a"

This reverts commit 097ad83.

Revert "Added support to update manifest app files from index.html"

This reverts commit 0a12a6f.
@kratiahuja kratiahuja merged commit 808479b into ember-fastboot:master Oct 30, 2019
@ef4
Copy link
Contributor

ef4 commented Mar 24, 2020

This is still unreleased, so the broken feature is floating around breaking things.

@kratiahuja
Copy link
Contributor

@ef4 do you want a release? I can release a new version.

@ef4
Copy link
Contributor

ef4 commented Mar 31, 2020

Yes, thanks that would be good.

@kratiahuja
Copy link
Contributor

@ef4 sorry for the delay. ember-cli-fastboot@2.2.2 is released

@rwjblue rwjblue added the bug label Jun 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants