Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use new BootOptions #70

Closed
wants to merge 2 commits into from

Conversation

victor-stone
Copy link

Not 100% sure if I did this right but it works for the latest canary

@@ -40,7 +40,10 @@ export default {

var promise;
Ember.run(function() {
promise = App.visit(url);
promise = App.visit(url {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing comma :)

@rwjblue
Copy link
Member

rwjblue commented Oct 8, 2015

@chancancode - r?

@chancancode
Copy link
Contributor

I'm working on a more complete patch: #71

I'll be on a plane soon, so I pushed it up so you can start poking at it. (It might or might not work, but that's the broad strokes)

@rwjblue
Copy link
Member

rwjblue commented Oct 8, 2015

Thanks @chancancode!

@victor-stone - I'm going to close this in favor of #71. We can always revisit (pun intended) if #71 ends up taking too long...

@rwjblue rwjblue closed this Oct 8, 2015
arjansingh pushed a commit to arjansingh/ember-cli-fastboot that referenced this pull request Oct 29, 2016
Exclude tests from shipped npm package
xg-wang pushed a commit to xg-wang/ember-cli-fastboot that referenced this pull request Nov 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants