Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fastBootDependencies => fastbootDependencies #278

Merged
merged 1 commit into from
Oct 13, 2016
Merged

fastBootDependencies => fastbootDependencies #278

merged 1 commit into from
Oct 13, 2016

Conversation

kellyselden
Copy link
Member

Resolves #277.

Will need to be updated in the docs as well.

danmcclain
danmcclain requested changes Oct 13, 2016
View reviewed changes
Copy link
Member

@danmcclain danmcclain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should deprecate fastBootDependencies as there may be some addons utilizing this currently that would break if we flat out remove this

@danmcclain
Copy link
Member

There are 18 matches for fastBootDependencies: https://github.com/search?q=fastBootDependencies&type=Code&utf8=✓

@kellyselden
Copy link
Member Author

OK. I didn't know the pre 1.0 deprecation policy.

@kellyselden
Copy link
Member Author

There are 18 matches for fastBootDependencies

That is a case insensitive search. 5 uses including mine.

@danmcclain
Copy link
Member

Valid, but I still think we should deprecate, since other addons are using it as well, plus it was publicly documented: https://github.com/ember-fastboot/fastboot-website/blob/9ee24367eca999e771164e3919c1c649c676e76a/markdown/docs/addon-author-guide.md#L230

@kellyselden
Copy link
Member Author

deprecated. now prints:

DEPRECATION: ember-addon.fastBootDependencies has been replaced with ember-addon.fastbootDependencies [addon: ember-cli-moment-shim]
DEPRECATION: ember-addon.fastBootDependencies has been replaced with ember-addon.fastbootDependencies [addon: ember-data-fetch-support]
DEPRECATION: ember-addon.fastBootDependencies has been replaced with ember-addon.fastbootDependencies [addon: ember-network]

@rwjblue
Copy link
Member

rwjblue commented Oct 13, 2016

Awesome, thank you for that @kellyselden!

kellyselden pushed a commit to kellyselden/fastboot-website that referenced this pull request Oct 13, 2016
fastBootDependencies => fastbootDependencies
7834364 
Related ember-fastboot/ember-cli-fastboot#278.
@kellyselden kellyselden mentioned this pull request Oct 13, 2016
Merged
@danmcclain danmcclain merged commit 4e2529a into ember-fastboot:master Oct 13, 2016
@danmcclain
Copy link
Member

Thanks @kellyselden!

@kellyselden kellyselden deleted the rename branch October 13, 2016 18:21
xg-wang pushed a commit to xg-wang/ember-cli-fastboot that referenced this pull request Nov 16, 2020
@rwjblue
Merge pull request ember-fastboot#278 from ember-fastboot/update-rele…
331148a 
…ase-setup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danmcclain danmcclain danmcclain approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kellyselden @danmcclain @rwjblue