Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Start the FastBoot server immediately when --build=false #257

Closed
wants to merge 8 commits into from
Closed

Start the FastBoot server immediately when --build=false #257

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
58a6ecd
start the fastboot server on task run with --build=false
treywood Sep 5, 2016
23fa387
call start instead of resetart
treywood Sep 6, 2016
44240c7
update run test after restart -> start
treywood Sep 6, 2016
3125eb1
updated the wrong test
treywood Sep 6, 2016
b669566
Merge branch 'master' into server-start-no-build
treywood Sep 13, 2016
84c05f1
call restart instead of start to clear require cache
treywood Sep 13, 2016
c49c08d
Merge remote-tracking branch 'upstream/master' into server-start-no-b…
treywood Oct 13, 2016
51c1cf8
Merge remote-tracking branch 'upstream/master' into server-start-no-b…
treywood Dec 16, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions lib/tasks/fastboot-server.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,9 @@ module.exports = CoreObject.extend({
debug('run');
const restart = () => this.restart(options);
this.addon.on('postBuild', restart);
if (options.build === false) {
restart(options);
}
},

start(options) {
Expand Down
6 changes: 6 additions & 0 deletions test/lib-tasks-fastboot-server-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,12 @@ describe('fastboot server task', function() {
addon.emit('postBuild');
expect(restartStub.called).to.be.ok;
});

it('calls restart immediately when --build=false', function() {
const restartStub = this.sinon.stub(task, 'restart');
task.run(new CommandOptions({ build: false }));
expect(restartStub.called).to.be.ok;
});
});

describe('restart', function() {
Expand Down