Replace SIGHUP event with a custom event #234
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes signalling across the process, since
SIGHUP
will terminate the process if nothing subscribes to this event (only on POSIX).So, in the case of
ember test
nothing is subscribed so it terminates the process after the build completes and before the test run.Unfortunately, counting listeners also does not work (reliably) since testem uses
signal-exit
which will make the count1
when testing. And by default,signal-exit
also terminates the process if no others are subscribed.This change moves off
process.emit
in place of custom eventing on the addon instance.Fixes #232
Review with https://github.com/ember-fastboot/ember-cli-fastboot/pull/234/files?w=1 since one file contained a mixture of tabs/spaces and my editor normalized them all to spaces.
/cc @rwjblue