Cautioning use of prototype extensions #231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based on the last meeting, adding to the README to caution that prototype extensions cannot be reliably used.
|
|
||
| Prototype extensions do not currently work across node "realms." Fastboot | ||
| applications operate in two realms, a normal node environment and a [virtual machine](https://nodejs.org/api/vm.html). Passing objects that originated from the normal realm will not contain the extension methods | ||
| inside of the sandbox environment. For this reason, it's encouraged to [disable prototype extensions](https://guides.emberjs.com/v2.3.0/configuring-ember/disabling-prototype-extensions/). |
There was a problem hiding this comment.
Could we link to a more current version of the Ember guides here? It'd be nice to link to an LTS (either 2.4 or 2.8 in a week or two ...)
There was a problem hiding this comment.
Updated link to 2.4.0
xg-wang
pushed a commit
to xg-wang/ember-cli-fastboot
that referenced
this pull request
Nov 16, 2020
General repo cleanup.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the last meeting, adding to the README to caution that prototype extensions cannot be reliably used.