Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds FastBoot service with cookies support #121

Merged
merged 7 commits into from
Feb 25, 2016
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,25 @@ Note that the `FastBoot` global is **only** available when running in
FastBoot mode. You should either guard against its presence or only use
it in FastBoot-only initializers.

### Cookies

You can access cookies for the current request via the `fastboot`
service.

```js
export default Ember.Route.extend({
fastboot: Ember.inject.service(),

model() {
let authToken = this.get('fastboot.cookies.auth');
// ...
}
});
```

The service's `cookies` property is an object containing the request's
cookies as key/value pairs.

## Known Limitations

While FastBoot is under active development, there are several major
Expand Down
7 changes: 7 additions & 0 deletions app/services/fastboot.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
import Ember from "ember";

let alias = Ember.computed.alias;

export default Ember.Service.extend({
cookies: alias('_fastbootInfo.cookies')
});
1 change: 1 addition & 0 deletions config/release.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@

// For details on each option run `ember help release`
module.exports = {
publish: true
// local: true,
// remote: 'some_remote',
// annotation: "Release %@",
Expand Down
4 changes: 3 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
"broccoli-asset-rev": "^2.0.0",
"chai": "^2.2.0",
"chai-fs": "peterkc/chai-fs#31deec5232297e2887a2ffb39b9081364c8e78e1",
"chalk": "^1.1.1",
"cpr": "^1.0.0",
"ember-cli": "1.13.15",
"ember-cli-addon-tests": "^0.2.0",
Expand All @@ -40,6 +41,7 @@
"exists-sync": "0.0.3",
"fs-extra": "^0.24.0",
"fs-promise": "^0.3.1",
"glob": "^7.0.0",
"mocha": "^2.2.4",
"request": "^2.55.0",
"rimraf": "^2.4.3",
Expand All @@ -61,7 +63,7 @@
"broccoli-merge-trees": "^1.1.1",
"broccoli-plugin": "^1.2.1",
"contextify": "^0.1.11",
"ember-fastboot-server": "0.4.3",
"ember-fastboot-server": "0.5.0",
"express": "^4.8.5",
"lodash": "^3.1.0",
"rsvp": "^3.0.16"
Expand Down
45 changes: 45 additions & 0 deletions tests/acceptance/cookies-test.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,45 @@
var chai = require('chai');
var expect = chai.expect;
var RSVP = require('rsvp');
var AddonTestApp = require('ember-cli-addon-tests').AddonTestApp;
var request = require('request');
var get = RSVP.denodeify(request);

describe('cookies', function() {
this.timeout(300000);

var app;

before(function() {

app = new AddonTestApp();

return app.create('cookies')
.then(function() {
return app.startServer({
command: 'fastboot',
additionalArguments: ['--serve-assets']
});
});
});

after(function() {
return app.stopServer();
});

it('makes cookies available via a service', function() {
var jar = request.jar();
var cookie = request.cookie('city=Cluj');

jar.setCookie(cookie, 'http://localhost:49741');

return get({
url: 'http://localhost:49741/list-cookies',
jar: jar
})
.then(function(response) {
expect(response.body).to.contain('Cookies: Cluj');
expect(response.body).to.contain('Cookies from Instance Initializer: Cluj');
});
});
});
4 changes: 4 additions & 0 deletions tests/fixtures/cookies/app/controllers/list-cookies.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
import Ember from "ember";

export default Ember.Controller.extend({
});
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
export default {
name: 'test-cookies',
initialize(applicationInstance) {
let listCookiesController = applicationInstance.lookup('controller:list-cookies');
let fastbootInfo = applicationInstance.lookup('info:-fastboot');

listCookiesController.set('instanceInitializerCookie', fastbootInfo.cookies.city);
}
};
12 changes: 12 additions & 0 deletions tests/fixtures/cookies/app/router.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
import Ember from 'ember';
import config from './config/environment';

var Router = Ember.Router.extend({
location: config.locationType
});

Router.map(function() {
this.route('list-cookies');
});

export default Router;
11 changes: 11 additions & 0 deletions tests/fixtures/cookies/app/routes/list-cookies.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
import Ember from "ember";

export default Ember.Route.extend({
fastboot: Ember.inject.service(),

model() {
return {
cookies: this.get('fastboot.cookies')
};
}
});
2 changes: 2 additions & 0 deletions tests/fixtures/cookies/app/templates/list-cookies.hbs
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
Cookies: {{model.cookies.city}}
Cookies from Instance Initializer: {{instanceInitializerCookie}}