Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS hot reloading not working #293

Closed
mike183 opened this issue Nov 26, 2016 · 9 comments
Closed

CSS hot reloading not working #293

mike183 opened this issue Nov 26, 2016 · 9 comments

Comments

@mike183
Copy link
Contributor

mike183 commented Nov 26, 2016

This appears to be a repeat of #212 and #226, the issue was previously resolved but seems to have resurfaced.

After some digging, it looks like that the regression was introduced in v1.0.0-beta.11, more specifically #282.

@lolmaus
Copy link

lolmaus commented Nov 26, 2016

Clarification: in my case, CSS hot reloading does work, but it is immediately followed by full tab refresh, defeating the purpose.

@mike183 Thank you for the heads-up. 🙇

@jakeleboeuf
Copy link

For me, a combination of this ember-network PR which was merged and released in v0.3.1 and this commit fix the issue.

@jurecuhalev
Copy link

jurecuhalev commented Jan 11, 2017

This also breaks live reloading with ember serve. For me installing new ember-network and current master of ember-cli-fastboot $0ba40ab6fe7b7675e32601a75726fdc2fc04f121 didn't fix the issue.

@jurecuhalev
Copy link

jurecuhalev commented Jan 17, 2017

Full reload happens because ember-cli:live-reload: files %a +1ms [ 'assets/frontend.css', 'package.json' ] gets package.json as changed file and triggers a full page reload.

package.json gets new timestamp every build, this triggers fs-tree-diff to include it changed files list.

@vlascik
Copy link
Contributor

vlascik commented May 7, 2017

@gandalfar is there any fix for this?

@mirague
Copy link

mirague commented May 7, 2017

Potentially same issue here, any pointers?

@jurecuhalev
Copy link

As a workaround, you could try: FASTBOOT_DISABLED=true ember serve. Since editing (S)CSS is something you don't often need fastboot enabled.

@stefanpenner
Copy link
Contributor

may be fixed by #369 cc @kratiahuja

@kratiahuja
Copy link
Contributor

kratiahuja commented May 8, 2017

Yup this should be fixed with the unified serve and build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants