Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS Updates cause page reload (navigation) instead of hot reload #212

Closed
rjfranco opened this issue Jun 13, 2016 · 5 comments
Closed

CSS Updates cause page reload (navigation) instead of hot reload #212

rjfranco opened this issue Jun 13, 2016 · 5 comments
Labels

Comments

@rjfranco
Copy link

When ember-cli-fastboot is included in a project, css updates cause a page refresh, not sure where in particular this originates, can be reproduced in a new 2.6.1 project where the only step taken is running ember install ember-cli-fastboot

@tomdale tomdale added the bug label Jun 24, 2016
@tomdale
Copy link
Contributor

tomdale commented Jun 24, 2016

I'm not familiar with how CSS hot reloading works in Ember CLI or how we might be interfering with it. That said, I think once we integrate better into the Ember CLI build pipeline by using public hooks (and avoiding a double build of the app) this should hopefully get resolved.

@stefanpenner
Copy link
Contributor

@tomdale css hot-reloading, diffs the output of the build, and reports all changed paths via websocket to livereload.js. If hot-reloading is broken, it is most likely because fast-boot causes everything to invalidate/rebuild and change.

@stefanpenner
Copy link
Contributor

For reference, the relevant code in ember-cli is: here https://github.com/ember-cli/ember-cli/blob/master/lib/tasks/server/livereload-server.js#L140-L153

@stefanpenner
Copy link
Contributor

stefanpenner commented Jul 25, 2016

There is a debug, here So running the following, will help inform further what is up:

DEBUG="ember-cli:live-reload:*" ember <w/e command>

@kpfefferle
Copy link

@rjfranco I think this issue can be closed now that #239 has landed. Confirm?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants