Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In Ember 2.7+ assets should be served from a rootURL-prefixed path #279

Closed
kfoisy opened this issue Oct 13, 2016 · 3 comments
Closed

In Ember 2.7+ assets should be served from a rootURL-prefixed path #279

kfoisy opened this issue Oct 13, 2016 · 3 comments

Comments

@kfoisy
Copy link

kfoisy commented Oct 13, 2016

In Ember 2.7+, using the baseURL has been deprecated (see http://emberjs.com/blog/2016/04/28/baseURL.html) and the assets should be served from a rootURL prefixed path.
@kfoisy
Copy link
Author

kfoisy commented Oct 13, 2016

I've submitted a pull request for this here: #273

@kfoisy
Copy link
Author

kfoisy commented Oct 27, 2016

@danmcclain @rwjblue Can I get any feedback on this issue/pull request? Are there any additional changes I need to make here?

@kratiahuja
Copy link
Contributor

hey @kfoisy sorry for the delay here. We have been re-working the entire build and serving pipeline for FastBoot. We recommend to use ember serve and ember fastboot is now deprecated and will be removed in rc builds. Closing this.

xg-wang pushed a commit to xg-wang/ember-cli-fastboot that referenced this issue Nov 16, 2020
@rwjblue
Merge pull request ember-fastboot#279 from ember-fastboot/migrate-to-…
6501efb 
…github-actions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kratiahuja @kfoisy