Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Target Support in RFC #268

Closed
tomdale opened this issue Sep 21, 2016 · 3 comments
Closed

Target Support in RFC #268

tomdale opened this issue Sep 21, 2016 · 3 comments
Labels

Comments

@tomdale
Copy link
Contributor

tomdale commented Sep 21, 2016

One thing that FastBoot would really benefit from is the first-class notion of "targets" in Ember CLI. Currently there is a notion of "environment," but this is not granular enough to support many use cases.

For example, Ember CLI implicitly assumes that the app is targeting the browser. But there are many other targets that may require different configuration information: FastBoot, Electron, PhoneGap, etc. Each of these likely has a production, development, etc. environment. The configuration information for production browser and production FastBoot likely overlap; therefore, we need the union of [target, environment] to capture the full spectrum of different configurations common in Ember development.

This issue is for tracking the development of this feature in Ember CLI so that we may eventually adopt it.

Note that this WIP RFC has been largely superseded after a discussion I had with @stefanpenner. Hopefully we can jot down the plan of action after this weekend's core team face-to-face meting.

@martletandco
Copy link
Contributor

Another thing to consider is the overlap with addons such as ember-cli-deploy, which has a deploy target. There may be some confusion if the difference isn't spelt out. I wonder if a different word such a 'platform' or 'type' could replace 'target' here (although those don't seem to fit as nicely).

@stefanpenner
Copy link
Contributor

related/complementary #264 (comment)

@stefanpenner
Copy link
Contributor

stefanpenner commented May 21, 2017

I believe we have addressed this on master, by simplifying how fastboot + ember apps work. This doesn't preclude a future of this, but means it is not longer on any critical path.

#356

xg-wang pushed a commit to xg-wang/ember-cli-fastboot that referenced this issue Nov 16, 2020
Append extra classes to existing ones in the body and html tags
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants