Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong route loaded in fastboot #208

Closed
Gaurav0 opened this issue Jun 3, 2016 · 12 comments
Closed

Wrong route loaded in fastboot #208

Gaurav0 opened this issue Jun 3, 2016 · 12 comments
Labels

Comments

@Gaurav0
Copy link
Contributor

Gaurav0 commented Jun 3, 2016

Given this router.js:

Router.map(function() {
  this.route('gist', {path: '/'}, function() {
    this.route('new', {path: '/'});
  });
  this.route('twiddles');
});

when going to localhost:3000/twiddles, the gist.new route is loaded in fastboot instead of the twiddles route which is loaded normally.

Result in Ember Twiddle

wrong route

@jasonmit
Copy link
Contributor

jasonmit commented Jun 3, 2016

What version of Ember?

@Gaurav0
Copy link
Contributor Author

Gaurav0 commented Jun 3, 2016

I'm running ember-cli 2.6 beta 3 with Ember 2.5.1

@tomdale
Copy link
Contributor

tomdale commented Jun 24, 2016

This seems bad. I can't think of any obvious reasons this would happen off the top of my head, since the route parsing logic doesn't depend on browser behavior. Maybe a bug in NoneLocation?

@tomdale tomdale added the bug label Jun 24, 2016
@kratiahuja
Copy link
Contributor

@Gaurav0 is this still an issue?

@Gaurav0
Copy link
Contributor Author

Gaurav0 commented May 21, 2017

Yes, can still reproduce.

@stefanpenner
Copy link
Contributor

@Gaurav0 on master or..

@Gaurav0
Copy link
Contributor Author

Gaurav0 commented May 22, 2017

Had tried on beta.18. I'll give rc.1 a try...

@stefanpenner
Copy link
Contributor

Hmm. It's unlikely there will be a difference. But worth a go....

My guess is that this may be an ember bug. If you could provide a repo with the minimal reproduction I will gladly debug this week.

@kratiahuja
Copy link
Contributor

Yeah I think if you can turn on debugg logging and see what is the incoming path fastboot gets that will help us nail down the issue. If the incomign path is wrong to the visit API, it would mean it's somewhere in the fastboot land.

@Gaurav0
Copy link
Contributor Author

Gaurav0 commented May 23, 2017

@kratiahuja It is getting the correct incoming path according to debugging. I guess the bug must be in Ember itself then?

I tried making a minimal reproduction, but it works correctly.

@kratiahuja
Copy link
Contributor

Yup it is an ember bug then.

@kratiahuja
Copy link
Contributor

Closing this since it isn't a fastboot issue.

xg-wang pushed a commit to xg-wang/ember-cli-fastboot that referenced this issue Nov 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants