npm run test:precook broken

[arjansingh]

Error: ENAMETOOLONG: name too long, stat '/Users/redacted/code/ember-cli-
fastboot/tmp/precooked_node_modules/ember-cli-fastboot/tmp/precooked_node_modules/ember-cli-
fastboot/tmp/precooked_node_modules/ember-cli-fastboot/tmp/precooked_node_modules/ember-cli-
fastboot/tmp/precooked_node_modules/ember-cli-fastboot/tmp/precooked_node_modules/ember-cli-
fastboot/tmp/precooked_node_modules/ember-cli-fastboot/tmp/precooked_node_modules/ember-cli-
fastboot/tmp/precooked_node_modules/ember-cli-fastboot/tmp/precooked_node_modules/ember-cli-
fastboot/tmp/precooked_node_modules/ember-cli-fastboot/tmp/precooked_node_modules/ember-cli-
fastboot/tmp/precooked_node_modules/ember-cli-fastboot/tmp/precooked_node_modules/ember-cli-
fastboot/tmp/precooked_node_modules/ember-cli-fastboot/tmp/precooked_node_modules/ember-cli-
fastboot/tmp/precooked_node_modules/ember-cli-fastboot/tmp/precooked_node_modules/ember-cli-
fastboot/tmp/precooked_node_modules/ember-cli-fastboot/tmp/precooked_node_modules/broccoli-
asset-rev/tests/fixtures/basic/output/assets/application-058eb02dfd08e347c40ae14e9f2e4600.js'

Tried precooking to save my self some time. It looks like it's doing some weird recursion. Anyone got a clue what's going on here?

[habdelra]

I was unable to repro this on Node v5.0.0/npm v3.3.6. What node/npm/OS are you on?

[arjansingh]

Node 4.2.0 on OSX/El Capitain.

I think we're going to have to support Node 4 since it's LTS. It doesn't make it impossible for me to develop. Just makes it slower.

I can understand if we prioritize other things.

[tomdale]

I think this should work on Node 4. Has anyone else run into this? @arjansingh, is there anything unusual going on with symlinking or something? Something weird in your Brocfile?

[danmcclain]

@arjansingh Is this related to the defaults issue you were having with your Brocfile/ember-cli-build?

[arjansingh]

@danmcclain No. The ember-cli-build build issue I ran into was for a company app I was working on, not ember-cli-fastboot development. We are passing defaults in this project's build file.

I did have fastboot and fastboot-express-middleware linked locally when I did this command. That might be a starting point to look into it.

FWIW, I ran it with node@4.4.0 locally with no dependencies sym linked and now get this error:

{ [Error: EEXIST: file already exists, symlink '/Users/asingh/code/ember-cli-fastboot' -> '/Users/asingh/code/ember-cli-fastboot/tmp/precooked_node_modules/ember-cli-fastboot']
  errno: -17,
  code: 'EEXIST',
  syscall: 'symlink',
  path: '/Users/asingh/code/ember-cli-fastboot',
  dest: '/Users/asingh/code/ember-cli-fastboot/tmp/precooked_node_modules/ember-cli-fastboot' }
[asingh@OSX: ember-cli-fastboot (master)] $rm -rf tmp/
[asingh@OSX: ember-cli-fastboot (master)] $npm run test:precook

> ember-cli-fastboot@1.0.0-beta.3 test:precook /Users/asingh/code/ember-cli-fastboot
> node node_modules/ember-cli-addon-tests/scripts/precook-node-modules.js

node@5.11.1 works @habdelra. I can also confirm that.

[stefanpenner]

still an issue on node 4. although i think we should re-work how we do tests to mitigate the need at all.

[kratiahuja]

Agreed. #396 is tracking on re-working the tests as well.