Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert to V2 format #346

Merged
merged 40 commits into from
Oct 11, 2021
Merged

Convert to V2 format #346

merged 40 commits into from
Oct 11, 2021

Conversation

ef4
Copy link
Contributor

@ef4 ef4 commented Mar 30, 2021

This converts to embroider v2 format, as one of our first examples of how to do that. The plan would be to land this and a few others and then extract the learned best-practices into an actual blueprint.

  • merge and release the new utils in @embroider/addon-shim we depend on
  • get embroider scenario passing -- there is a silly case embroider doesn't handle correctly in adjust-imports-plugin that is under-tested
  • review top-level dotfiles for anything leftover that isn't needed
  • document how to manage dependencies of test app
  • document how to upgrade test app
  • document scenarios.js and add to scripts as appropriate
    • how to run all
    • how to list
    • how to run one
    • how to output and debug one
  • add default output from scenario-tester to gitignore
  • nice-to-have: Support node_modules/.bin when linking deps stefanpenner/node-fixturify-project#56

@ef4 ef4 marked this pull request as ready for review September 30, 2021 09:40
@ef4
Copy link
Contributor Author

ef4 commented Oct 1, 2021

This is a complete example now.

There are some further enhancements I have coming down the pipe to make the DX more familiar. The big one is adding a build step that takes care of template inlining so that the authored addon code can use normal template colocation, while the published code will be explicit.

@ef4
Copy link
Contributor Author

ef4 commented Oct 11, 2021

Now this has its own small & fast build pipeline based on rollup. It takes care of template-colocation, and it generates your appTree for you, so you don't need to keep all those reexport-only files around.

@ef4
Copy link
Contributor Author

ef4 commented Oct 11, 2021

I'm going to merge this to make it easier to iterate on. Happy to take feedback and get some consensus before cutting a release.

@ef4 ef4 merged commit 3b39cd8 into master Oct 11, 2021
@delete-merged-branch delete-merged-branch bot deleted the convert-to-v2-format branch October 11, 2021 21:31
@rwjblue rwjblue changed the title Convert to v2 format Convert to V2 format Oct 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants