Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly clean up lsp--update-signature-help-hook #4550

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sstraust
Copy link

lsp--update-signature-help-hook is not correctly removed when lsp-managed-mode is disabled.

Steps to reproduce:
open https://git.sr.ht/~davidcode/emacs-lsp-problem, and then try to disable lsp-mode and lsp-managed-mode

check the value of the variable post-self-insert-hook.

verified this change by running lsp-managed-mode (to turn it on and off) with the applied changes, and the post hook is no longer visible.

This has a real impact, as it pops up documentation strings, even after LSP mode is turned off.

Paired with David Howard on finding this issue.

@sstraust
Copy link
Author

I see that my errors mention that lsp-byte-compilation test failed. I'm assuming there's some compilation step I'm supposed to run before submitting this change, but I'm not sure what it is.

Any pointers on where to find it?

(i did read the contributing guidelines, but this is my first attempt to contribute to a major elisp project, so i might be very dumb lol)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant