Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add mint-lang client #3679

Merged
merged 4 commits into from
Aug 19, 2022
Merged

Add mint-lang client #3679

merged 4 commits into from
Aug 19, 2022

Conversation

zw963
Copy link
Contributor

@zw963 zw963 commented Aug 17, 2022 •
edited
Loading

Add elementary mint support. #3678

@github-actions github-actions bot added the client One or more of lsp-mode language clients label Aug 17, 2022
@yyoncho
Copy link
Member

yyoncho commented Aug 18, 2022

Can you add an entry in clients.json?

@jcs090218
Copy link
Member

Maybe update the CHANGELOG as well?

@zw963
Copy link
Contributor Author

zw963 commented Aug 18, 2022

Done, please check.

There is one more issue, i have to (require 'lsp-mint) manually in my own to make those config take effect, but, it seem like some others client will load automatically when lsp is running in mode hook, right?

@yyoncho
Copy link
Member

yyoncho commented Aug 18, 2022

You have to update lsp-client-packages just like the sample PR I linked.

@zw963
Copy link
Contributor Author

zw963 commented Aug 18, 2022

done, please have a look, thank you.

@yyoncho yyoncho merged commit 37c2adf into emacs-lsp:master Aug 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yyoncho yyoncho yyoncho approved these changes

Assignees
No one assigned
Labels
client One or more of lsp-mode language clients documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zw963 @yyoncho @jcs090218