Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xLog should not crash app but give helpful hints when there in an invalid Json #103

Closed
shipsywor opened this issue Jun 12, 2021 · 2 comments

Comments

@shipsywor
Copy link

When the json is invalid, xLog crashes the Android app and gives error "format parse ..."

Instead of doing that it should either give helpful validation errors like this site: https://jsonformatter.curiousconcept.com/#

Or simply print in the logcat that the "json is invalid". The App should NOT crash.

This is what https://github.com/orhanobut/logger does:

The important part is that App is not crashed!

k_2021-06-12_20-18-34

Please think of a more thoughtful way of dealing with invalid json errors. Crashing the app is very inconvenient.

@elvishew
Copy link
Owner

@shipsywor Thanks for your reasonable suggestion, will do it.

@elvishew
Copy link
Owner

v1.10.0 is released, close

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants