Update heck dep + add .idea to gitignore #57
clippy
13 warnings
Details
Results
Message level | Amount |
---|---|
Internal compiler error | 0 |
Error | 0 |
Warning | 13 |
Note | 0 |
Help | 0 |
Versions
- rustc 1.73.0 (cc66ad468 2023-10-03)
- cargo 1.73.0 (9c4383fb5 2023-08-26)
- clippy 0.1.73 (cc66ad4 2023-10-03)
Annotations
Check warning on line 436 in src/vec_dyn.rs
github-actions / clippy
deref which would be done by auto-deref
warning: deref which would be done by auto-deref
--> src/vec_dyn.rs:436:33
|
436 | self.data.data.push(&*bytes);
| ^^^^^^^ help: try: `&bytes`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref
= note: `#[warn(clippy::explicit_auto_deref)]` on by default
Check warning on line 590 in src/slice.rs
github-actions / clippy
method `into_iter` can be confused for the standard trait method `std::iter::IntoIterator::into_iter`
warning: method `into_iter` can be confused for the standard trait method `std::iter::IntoIterator::into_iter`
--> src/slice.rs:581:5
|
581 | / pub fn into_iter(self) -> impl Iterator<Item = ValueMut<'a, V>>
582 | | where
583 | | V: Clone,
584 | | {
... |
589 | | })
590 | | }
| |_____^
|
= help: consider implementing the trait `std::iter::IntoIterator` or choosing a less ambiguous method name
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait
Check warning on line 228 in src/slice.rs
github-actions / clippy
method `into_iter` can be confused for the standard trait method `std::iter::IntoIterator::into_iter`
warning: method `into_iter` can be confused for the standard trait method `std::iter::IntoIterator::into_iter`
--> src/slice.rs:219:5
|
219 | / pub fn into_iter(self) -> impl Iterator<Item = ValueRef<'a, V>>
220 | | where
221 | | V: Clone,
222 | | {
... |
227 | | })
228 | | }
| |_____^
|
= help: consider implementing the trait `std::iter::IntoIterator` or choosing a less ambiguous method name
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait
Check warning on line 692 in src/vec_copy.rs
github-actions / clippy
dereferencing a struct pattern where every field's pattern takes a reference
warning: dereferencing a struct pattern where every field's pattern takes a reference
--> src/vec_copy.rs:689:13
|
689 | let &VecCopy {
| _____________^
690 | | ref data,
691 | | ref vtable,
692 | | } = self;
| |_________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference
= note: `#[warn(clippy::needless_borrowed_reference)]` on by default
help: try removing the `&` and `ref` parts
|
689 ~ let VecCopy {
690 ~ data,
691 ~ vtable,
|
Check warning on line 681 in src/slice_copy.rs
github-actions / clippy
method `into_iter` can be confused for the standard trait method `std::iter::IntoIterator::into_iter`
warning: method `into_iter` can be confused for the standard trait method `std::iter::IntoIterator::into_iter`
--> src/slice_copy.rs:672:5
|
672 | / pub fn into_iter(self) -> impl Iterator<Item = CopyValueMut<'a, V>>
673 | | where
674 | | V: Clone,
675 | | {
... |
680 | | })
681 | | }
| |_____^
|
= help: consider implementing the trait `std::iter::IntoIterator` or choosing a less ambiguous method name
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait
Check warning on line 413 in src/slice_copy.rs
github-actions / clippy
manual slice size calculation
warning: manual slice size calculation
--> src/slice_copy.rs:413:17
|
413 | slice.len() * element_size,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `std::mem::size_of_val(slice)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_slice_size_calculation
Check warning on line 273 in src/slice_copy.rs
github-actions / clippy
method `into_iter` can be confused for the standard trait method `std::iter::IntoIterator::into_iter`
warning: method `into_iter` can be confused for the standard trait method `std::iter::IntoIterator::into_iter`
--> src/slice_copy.rs:264:5
|
264 | / pub fn into_iter(self) -> impl Iterator<Item = CopyValueRef<'a, V>>
265 | | where
266 | | V: Clone,
267 | | {
... |
272 | | })
273 | | }
| |_____^
|
= help: consider implementing the trait `std::iter::IntoIterator` or choosing a less ambiguous method name
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait
= note: `#[warn(clippy::should_implement_trait)]` on by default
Check warning on line 50 in src/slice_copy.rs
github-actions / clippy
manual slice size calculation
warning: manual slice size calculation
--> src/slice_copy.rs:50:17
|
50 | slice.len() * element_size,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `std::mem::size_of_val(slice)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_slice_size_calculation
= note: `#[warn(clippy::manual_slice_size_calculation)]` on by default
Check warning on line 304 in src/vec_void.rs
github-actions / clippy
this expression borrows a value the compiler would automatically borrow
warning: this expression borrows a value the compiler would automatically borrow
--> src/vec_void.rs:304:25
|
304 | (&mut v[orig_len..]).as_mut_ptr() as *mut MaybeUninit<u8>,
| ^^^^^^^^^^^^^^^^^^^^ help: change this to: `v[orig_len..]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
= note: `#[warn(clippy::needless_borrow)]` on by default
Check warning on line 651 in src/value.rs
github-actions / clippy
the following explicit lifetimes could be elided: 'b
warning: the following explicit lifetimes could be elided: 'b
--> src/value.rs:651:17
|
651 | pub fn swap<'b>(&mut self, other: &mut ValueMut<'b, V>) {
| ^^ ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
= note: `#[warn(clippy::needless_lifetimes)]` on by default
help: elide the lifetimes
|
651 - pub fn swap<'b>(&mut self, other: &mut ValueMut<'b, V>) {
651 + pub fn swap(&mut self, other: &mut ValueMut<'_, V>) {
|
Check warning on line 609 in src/value.rs
github-actions / clippy
deref on an immutable reference
warning: deref on an immutable reference
--> src/value.rs:609:20
|
609 | bytes: &*self.bytes,
| ^^^^^^^^^^^^ help: if you would like to reborrow, try removing `&*`: `self.bytes`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrow_deref_ref
Check warning on line 104 in src/vtable.rs
github-actions / clippy
deref on an immutable reference
warning: deref on an immutable reference
--> src/vtable.rs:104:34
|
104 | VTableRef::Box(v) => &*v,
| ^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrow_deref_ref
help: if you would like to reborrow, try removing `&*`
|
104 | VTableRef::Box(v) => v,
| ~
help: if you would like to deref, try using `&**`
|
104 | VTableRef::Box(v) => &**v,
| ~~~~
Check warning on line 66 in src/copy_value.rs
github-actions / clippy
deref on an immutable reference
warning: deref on an immutable reference
--> src/copy_value.rs:66:9
|
66 | &*self
| ^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrow_deref_ref
= note: `#[warn(clippy::borrow_deref_ref)]` on by default
help: if you would like to reborrow, try removing `&*`
|
66 | self
|
help: if you would like to deref, try using `&**`
|
66 | &**self
|