cashurpc #6
Draft
cashurpc #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
March 17, 2024 10:46
Added new protobuf definitions to the cashu RPC handling framework for managing states and state proofs. These message types will facilitate state checking and updating. Protobuf definitions include `PostCheckStateRequest`, `PostCheckStateResponse`, and `States` among others.
# Conflicts: # cmd/nutw/nutw.go # wallet/client.go # wallet/storage/bolt.go # wallet/storage/storage.go # wallet/wallet.go
callebtc
reviewed
Mar 31, 2024
callebtc
reviewed
Mar 31, 2024
callebtc
reviewed
Mar 31, 2024
added 4 commits
May 3, 2024 13:33
# Conflicts: # cashu/cashu.go # cashu/nuts/nut01/nut01.go # cashu/nuts/nut02/nut02.go # cashu/nuts/nut03/nut03.go # cashu/nuts/nut04/nut04.go # cashu/nuts/nut05/nut05.go # cashu/nuts/nut06/nut06.go # cmd/nutw/nutw.go # go.mod # go.sum # mint/config.go # mint/db.go # mint/lightning/lnd.go # mint/mint.go # mint/server.go # wallet/storage/bolt.go # wallet/wallet.go
|
resolved changes from @callebtc
|
to what does it need to change? |
|
Tthe contact infos currently defined as an array of arrays with at most 2 elements. The first element represents the key, while the second element is the value. This should probably be update to an array of objects. current state: desired state (already implemented in this PR) I am going to open a new pull request in the nuts repository and propose the change to the protocol there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.