Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: set package-manager-strict to false #2873

Merged
merged 1 commit into from
May 28, 2024

Conversation

Shinigami92
Copy link
Member

like in vite, set package-manager-strict to false so pnpm v9 can locally be used

@Shinigami92 Shinigami92 added the c: infra Changes to our infrastructure or project setup label May 27, 2024
@Shinigami92 Shinigami92 self-assigned this May 27, 2024
Copy link

stackblitz bot commented May 27, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

netlify bot commented May 27, 2024

Deploy Preview for elk-zone ready!

Name Link
🔨 Latest commit 845afc7
🔍 Latest deploy log https://app.netlify.com/sites/elk-zone/deploys/665599e09b19f200085f54e6
😎 Deploy Preview https://deploy-preview-2873--elk-zone.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented May 27, 2024

Deploy Preview for elk-docs canceled.

Name Link
🔨 Latest commit 845afc7
🔍 Latest deploy log https://app.netlify.com/sites/elk-docs/deploys/665599e0c1306100080c93de

@antfu
Copy link
Member

antfu commented May 28, 2024

Any issue you encountered with it makes you want to disable it? For me it works fine

@Shinigami92
Copy link
Member Author

Any issue you encountered with it makes you want to disable it? For me it works fine

It only happens if you use a pnpm version not matching the exact needed version (not using corepack by the way)

@antfu
Copy link
Member

antfu commented May 28, 2024

So why not corepack? In a way I would encourage every contributor to enable corepack (I believe that's also why pnpm add this)

@Shinigami92
Copy link
Member Author

Why did we allowed it in Vite but not here?
vitejs/vite#16565

This setting does not affect corepack users, but only makes life easier for non corepack users

@Shinigami92 Shinigami92 force-pushed the chore-set-package-manager-strict branch from 8f0a926 to 845afc7 Compare May 28, 2024 08:46
@antfu
Copy link
Member

antfu commented May 28, 2024

I don't hold a strong opinion on merging this PR - if the others agree, I think we could move on.

But in a way, I think there are true benefits to asking everyone to enable corepack. Otherwise, I'd say it's better to challenge ppm to revert that option with your counterpoints, instead of disabling it manually in every project. Would you agree?

@Shinigami92
Copy link
Member Author

I don't hold a strong opinion on merging this PR - if the others agree, I think we could move on.

But in a way, I think there are true benefits to asking everyone to enable corepack. Otherwise, I'd say it's better to challenge ppm to revert that option with your counterpoints, instead of disabling it manually in every project. Would you agree?

I did not try to fight yet against pnpm with an issue, but I see nearly in all my related projects that this config was made and so I might report a list to pnpm-repo later on.
That config also just converts an error to a warning. Maybe that warning should be the default instead of hard-erroring and holding back normal developing.

@patak-dev
Copy link
Member

I don't have a strong opinion on this one either side.

@patak-dev patak-dev removed their request for review May 28, 2024 12:10
@Shinigami92
Copy link
Member Author

Then lets merge it for now, as it does not have negative effects
If pnpm one day switches to be more non-destructive in this case, we can revert the setting

@antfu antfu merged commit 0b207c3 into main May 28, 2024
15 checks passed
@antfu antfu deleted the chore-set-package-manager-strict branch May 28, 2024 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: infra Changes to our infrastructure or project setup
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants