Adds a v shortcut to open/focus the version select
#1916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andersonmcook
commented
Jun 10, 2024
| @@ -136,13 +143,13 @@ export function openSidebar () { | |||
| sessionStorage.setItem('sidebar_state', 'opened') | |||
| qs(SIDEBAR_TOGGLE_SELECTOR).setAttribute('aria-expanded', 'true') | |||
|
|
|||
| requestAnimationFrame(() => { | |||
There was a problem hiding this comment.
openSidebar and closeSidebar did not actually return Promises. I made a small update so that pressing v with a closed sidebar will pop open the sidebar and then open/focus the version select.
andersonmcook
commented
Jun 10, 2024
| @@ -34,6 +35,11 @@ export const keyboardShortcuts = [ | |||
| hasModifier: true, | |||
| action: searchKeyAction | |||
| }, | |||
| { | |||
| key: 'v', | |||
| description: 'Open/focus version select', | |||
There was a problem hiding this comment.
We could use 'showPicker' in HTMLSelectElement.prototype to determine the language.
andersonmcook
commented
Jun 10, 2024
| if (select) { | ||
| select.focus() | ||
|
|
||
| // Prevent subsequent 'v' press from submitting form |
There was a problem hiding this comment.
This confused me, but the v submits the form. You can test this on the main hexdocs page for Elixir.
Click the version select without selecting a version, press escape (the select is still focused), press v, and it will take you to the version below your current selection.
|
💚 💙 💜 💛 ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When searching for docs in a search engine, the results don't always include the latest version as the first choice. This adds a
vshortcut that will open the version select (if the user's browser supports it, otherwise it will focus it) to make selecting versions easier.