Fix dialyzer issues with interval extension, part 2

[greg-rychlewski]

Really not sure about the latest warning

deps/postgrex/lib/postgrex/type_module.ex:1084:call
The function call will not succeed.

:erlang.band(_mod :: nil, 65535)

will never return since the 1st arguments differ
from the success typing arguments:

(integer(), integer())

@oliver-kriska could you try this branch before we merge? ty

[oliver-kriska]

unfortunately still same issue

deps/postgrex/lib/postgrex/type_module.ex:1084:call
The function call will not succeed.

:erlang.band(_ :: nil, 65535)

will never return since the 1st arguments differ
from the success typing arguments:

(integer(), integer())

[greg-rychlewski]

generated: true it is :) . this warning seems pretty unreasonable

[oliver-kriska]

still same

def decode(type) do
      quote location: :keep, generated: true do
        <<16::int32(), microseconds::int64(), days::int32(), months::int32()>> ->
          type_mod = var!(mod)
          precision = if type_mod, do: type_mod &&& unquote(@precision_mask)

          unquote(__MODULE__).decode_interval(
            microseconds,
            days,
            months,
            precision,
            unquote(type)
          )
      end
    end

and error:

deps/postgrex/lib/postgrex/type_module.ex:1084:call
The function call will not succeed.

:erlang.band(_ :: nil, 65535)

will never return since the 1st arguments differ
from the success typing arguments:

(integer(), integer())

[josevalim]

@greg-rychlewski maybe move the band to the decode_interval functions?

[greg-rychlewski]

@oliver-kriska sorry, one more time when you have the chance :)

[oliver-kriska]

it works. Good job and thank you :)

[greg-rychlewski]

thanks to @josevalim . i had no clue what was happening