Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix filtering of rooms when supplying the destination query parameter to /_synapse/admin/v1/federation/destinations/<destination>/rooms #17077

Merged
merged 4 commits into from
Apr 26, 2024
Merged

Fix filtering of rooms when supplying the destination query parameter to /_synapse/admin/v1/federation/destinations/<destination>/rooms #17077

merged 4 commits into from
Apr 26, 2024

Commits on Apr 12, 2024

  1. Write a test to verify the invalid behaviour 

    This test indeed fails due to the endpoint
returning extra rooms.

`_create_destination_rooms` was updated to allow specifying the
`destination` that would be associated with the newly-created rooms.
    @anoadragon453
    anoadragon453 committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    2a55ad3 View commit details
    Browse the repository at this point in the history

  2. Filter rooms by destination. 

    Seems this was just missed in the original implementation.
    @anoadragon453
    anoadragon453 committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    1785ed9 View commit details
    Browse the repository at this point in the history

  3. changelog

    @anoadragon453
    anoadragon453 committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    a45935a View commit details
    Browse the repository at this point in the history

Commits on Apr 15, 2024

  1. De-flake test 

    Passing of the test was dependent on the order of the items in the
returned lists. But no longer!
    @anoadragon453
    anoadragon453 committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    e84feef View commit details
    Browse the repository at this point in the history