Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add timezone to user profile #20

Merged
merged 27 commits into from
Sep 12, 2024
Merged

Add timezone to user profile #20

merged 27 commits into from
Sep 12, 2024

Conversation

Half-Shot
Copy link
Member

@Half-Shot Half-Shot commented Sep 10, 2024

Migrated from matrix-org/matrix-react-sdk#12967
Implements MSC4175
Depends on matrix-org/matrix-js-sdk#4391

Design provided at https://www.figma.com/design/gpxHFDTNK796n84r1ZxYG2?node-id=1360-28954#941702635

This provides a basic presentation of a user's current time & timezone on their profile. It also adds a setting to allow publishing the time.

Timezone in user profile

image

Timezone publish setting

image

Checklist

  • Tests written for new code (and old code if feasible).
  • New or updated public/exported symbols have accurate TSDoc documentation.
  • Linter and other CI checks pass.
  • Sign-off given on the changes (see CONTRIBUTING.md).

Signed-off-by: Will Hunt cla@half-shot.uk

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@Half-Shot Half-Shot changed the title Hs/timezone publish to profile Add timezone to user profile Sep 10, 2024
@@ -1841,10 +1841,25 @@
"files_button": "Pliki",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes came from 33c9c04, I don't know whether I should remove them from my commit list to make the CI pass or just ignore it?

@Half-Shot
Copy link
Member Author

@dbkr PR ended up moving here, if you wouldn't mind a re-review (sorry!)

@dbkr
Copy link
Member

dbkr commented Sep 10, 2024

Looks good. For the end to end tests, you'll just need to run the command to update the screenshot file. For sonarcloud coverage... it's whining because the code to update / delete the timezone is not tested, which feels legit I think. Any chance of a test for this?

@Half-Shot
Copy link
Member Author

@dbkr New tests added and screenshots fixed, I think this is ready for you to look at.

Copy link

sonarcloud bot commented Sep 12, 2024

@Half-Shot
Copy link
Member Author

(I have CLA'd, but it seems to think I have not)

@dbkr dbkr added this pull request to the merge queue Sep 12, 2024
Merged via the queue into develop with commit eae9d9e Sep 12, 2024
26 of 27 checks passed
@dbkr dbkr deleted the hs/timezone-publish-to-profile branch September 12, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants