Kieran gould/12hourtimestamp #3961
Conversation
| @@ -94,7 +94,7 @@ limitations under the License. | |||
| */ | |||
| .mx_EventTile_selected .mx_EventTile_line { | |||
| border-left: $accent-color 5px solid; | |||
| padding-left: 60px; | |||
| padding-left: 100px; | |||
There was a problem hiding this comment.
please let's not change the whole layout of the app just to provide the option of 12h timestamps ;)
See comments of https://github.com/matrix-org/matrix-react-sdk/pull/903/files#r117365391
| { DateUtils.formatTime(date) } | ||
| </span> | ||
| ); | ||
| if (UserSettingsStore.getSyncedSetting('showTwelveHourTimestamps')) { |
There was a problem hiding this comment.
technically the state of render() should depend only on props & state rather than js-sdk state, but i'm happy to ignore this for now :)
| </span> | ||
| ); | ||
| } | ||
| else { |
There was a problem hiding this comment.
else should be on previous line for readability :)
| </span> | ||
| ); | ||
| if (UserSettingsStore.getSyncedSetting('showTwelveHourTimestamps')) { | ||
| return ( |
There was a problem hiding this comment.
indentation should be 4 spaces pleaseeeee
| @@ -112,4 +112,3 @@ limitations under the License. | |||
| .mx_FilePanel .mx_EventTile_selected .mx_EventTile_line { | |||
| padding-left: 0px; | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
probably not worth messing up latest commit on this file for this
| @@ -263,6 +263,10 @@ limitations under the License. | |||
| cursor: pointer; | |||
| } | |||
|
|
|||
| .mx_EventTile_e2eIcon_12hr { | |||
| padding-left: 5px; | |||
|
this lgtm other than concerns on the react-sdk one (including how to structure the CSS) |
Kieran-Gould
force-pushed
the
kieran-gould/12hourtimestamp
branch
from
3343de7
to
cae62c8
Compare
|
lgtm having fixed typo, i think |
Linked to: matrix-org/matrix-react-sdk#903