CSS for Leaflet and location events. #2774
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ara4n
reviewed
Dec 21, 2016
| @@ -0,0 +1,4 @@ | |||
| .mx_LocationMap { | |||
There was a problem hiding this comment.
technically this should be two different classes, one for LocationInputDialog and the other for MLocationBody, in order to avoid unnecessarily coupling between the two components and to preserve the naming scheme of the CSS. I'm happy to turn a blind eye to it here, though, as long as it can be moved into common.css rather than looking like it's specific to LocationInputDialog.css.
There was a problem hiding this comment.
Nah, I'll keep them separate just in case of wanting to fiddle with them later.
|
lgtm other than one comment |
Half-Shot
force-pushed
the
location-events
branch
2 times, most recently
from
4e52537
to
6384234
Compare
Half-Shot
force-pushed
the
location-events
branch
from
6384234
to
72b310c
Compare
Half-Shot
force-pushed
the
location-events
branch
from
72b310c
to
7c5c3de
Compare
|
It looks like the react-sdk side was closed for this. Thanks again for the PR! See matrix-org/matrix-react-sdk#596 (comment) for why the react-sdk PR was closed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.