Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix style lint issues #16732

Merged
merged 2 commits into from
Mar 23, 2021
Merged

Fix style lint issues #16732

merged 2 commits into from
Mar 23, 2021

Conversation

turt2live
Copy link
Member

@turt2live turt2live commented Mar 19, 2021 •
edited
Loading

Output from linter:

$ stylelint 'res/css/**/*.scss'
res/css/structures/ErrorView.scss
 25:20   ✖  Expected "DXImageTransform.Microsoft.gradient" to be "dximagetransform.microsoft.gradient"   function-name-case               
 25:56   ✖  Unexpected whitespace after "(" in a single-line function                                    function-parentheses-space-inside
 25:103  ✖  Expected single space after "," in a single-line function                                    function-comma-space-after       
 25:118  ✖  Unexpected whitespace before ")" in a single-line function                                   function-parentheses-space-inside
 44:27   ✖  Expected "#03B381" to be "#03b381"                                                           color-hex-case                   
 57:16   ✖  Expected "#2E2F32" to be "#2e2f32"                                                           color-hex-case                   
 98:16   ✖  Expected "#368BD6" to be "#368bd6"                                                           color-hex-case
error Command failed with exit code 2.

See matrix-org/pipelines#138 for enabling this linter.

@turt2live turt2live mentioned this pull request Mar 19, 2021
Merged
@turt2live turt2live requested a review from a team March 19, 2021 22:30
jryans
jryans approved these changes Mar 23, 2021
View reviewed changes
res/css/structures/ErrorView.scss
@@ -22,7 +22,7 @@ limitations under the License.
background: -moz-linear-gradient(top, #c5e0f7 0%, #ffffff 100%);
background: -webkit-linear-gradient(top, #c5e0f7 0%, #ffffff 100%);
background: linear-gradient(to bottom, #c5e0f7 0%, #ffffff 100%);
filter: progid:DXImageTransform.Microsoft.gradient( startColorstr='#c5e0f7', endColorstr='#ffffff',GradientType=0 );
filter: progid:dximagetransform.microsoft.gradient(startColorstr='#c5e0f7', endColorstr='#ffffff', GradientType=0);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bit surprised we have this ~2010 style attempt to appease ancient IE just to show a gradient... 😅

@turt2live turt2live merged commit 0a793d2 into develop Mar 23, 2021
@turt2live turt2live deleted the travis/style-lint branch March 23, 2021 13:32
netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this pull request May 1, 2021
@Midar
Update chat/element-web to 1.7.26
e8e9c66 
Changes in [1.7.26](https://github.com/vector-im/element-web/releases/tag/v1.7.26) (2021-04-26)
===============================================================================================
[Full Changelog](element-hq/element-web@v1.7.26-rc.1...v1.7.26)

 * Upgrade to React SDK 3.19.0 and JS SDK 10.0.0

Changes in [1.7.26-rc.1](https://github.com/vector-im/element-web/releases/tag/v1.7.26-rc.1) (2021-04-21)
=========================================================================================================
[Full Changelog](element-hq/element-web@v1.7.25...v1.7.26-rc.1)

 * Upgrade to React SDK 3.19.0-rc.1 and JS SDK 10.0.0-rc.1
 * Translations update from Weblate
   [\#17031](element-hq/element-web#17031)
 * Bump ssri from 6.0.1 to 6.0.2
   [\#17010](element-hq/element-web#17010)
 * Fix `NODE_ENV` value for CI environments
   [\#17003](element-hq/element-web#17003)
 * Use React production mode in CI builds
   [\#16969](element-hq/element-web#16969)
 * Labs documentation for DND mode
   [\#16962](element-hq/element-web#16962)
 * Rename blackboxing to new option ignore list
   [\#16965](element-hq/element-web#16965)
 * Remove velocity-animate from lockfile
   [\#16963](element-hq/element-web#16963)
 * Add mobile download link configuration
   [\#16890](element-hq/element-web#16890)
 * Switch develop to not-staging Scalar by default
   [\#16883](element-hq/element-web#16883)
 * Support a config option to skip login/welcome and go to SSO
   [\#16880](element-hq/element-web#16880)

Changes in [1.7.25](https://github.com/vector-im/element-web/releases/tag/v1.7.25) (2021-04-12)
===============================================================================================
[Full Changelog](element-hq/element-web@v1.7.25-rc.1...v1.7.25)

 * Upgrade to React SDK 3.18.0 and JS SDK 9.11.0

Changes in [1.7.25-rc.1](https://github.com/vector-im/element-web/releases/tag/v1.7.25-rc.1) (2021-04-07)
=========================================================================================================
[Full Changelog](element-hq/element-web@v1.7.24...v1.7.25-rc.1)

 * Upgrade to React SDK 3.18.0-rc.1 and JS SDK 9.11.0-rc.1
 * Translations update from Weblate
   [\#16882](element-hq/element-web#16882)
 * Revert "Docker image: serve pre-compressed assets using gzip_static"
   [\#16838](element-hq/element-web#16838)
 * Move native node modules documentation to element-desktop
   [\#16814](element-hq/element-web#16814)
 * Add user settings for warn before exit
   [\#16781](element-hq/element-web#16781)
 * Change ISSUE_TEMPLATE bold lines to proper headers
   [\#16768](element-hq/element-web#16768)
 * Add example for deployment into Kubernetes
   [\#16447](element-hq/element-web#16447)
 * Create bare-bones `PULL_REQUEST_TEMPLATE.md`
   [\#16770](element-hq/element-web#16770)
 * Add webpack config and labs flag docs for voice messages
   [\#16705](element-hq/element-web#16705)

Changes in [1.7.24](https://github.com/vector-im/element-web/releases/tag/v1.7.24) (2021-03-29)
===============================================================================================
[Full Changelog](element-hq/element-web@v1.7.24-rc.1...v1.7.24)

 * Upgrade to React SDK 3.17.0 and JS SDK 9.10.0

Changes in [1.7.24-rc.1](https://github.com/vector-im/element-web/releases/tag/v1.7.24-rc.1) (2021-03-25)
=========================================================================================================
[Full Changelog](element-hq/element-web@v1.7.23...v1.7.24-rc.1)

 * Upgrade to React SDK 3.17.0-rc.2 and JS SDK 9.10.0-rc.1
 * Translations update from Weblate
   [\#16766](element-hq/element-web#16766)
 * Docker image: serve pre-compressed assets using gzip_static
   [\#16698](element-hq/element-web#16698)
 * Fix style lint issues
   [\#16732](element-hq/element-web#16732)
 * Updated expected webpack output in setup guide
   [\#16740](element-hq/element-web#16740)
 * Docs for `loginForWelcome`
   [\#16468](element-hq/element-web#16468)
 * Disable rageshake persistence if no logs would be submitted
   [\#16697](element-hq/element-web#16697)

Changes in [1.7.23](https://github.com/vector-im/element-web/releases/tag/v1.7.23) (2021-03-15)
===============================================================================================
[Full Changelog](element-hq/element-web@v1.7.23-rc.1...v1.7.23)

 * Upgrade to React SDK 3.16.0 and JS SDK 9.9.0

Changes in [1.7.23-rc.1](https://github.com/vector-im/element-web/releases/tag/v1.7.23-rc.1) (2021-03-10)
=========================================================================================================
[Full Changelog](element-hq/element-web@v1.7.22...v1.7.23-rc.1)

 * Upgrade to React SDK 3.16.0-rc.2 and JS SDK 9.9.0-rc.1
 * Translations update from Weblate
   [\#16655](element-hq/element-web#16655)
 * Improve docs for customisations
   [\#16652](element-hq/element-web#16652)
 * Update triage guide to match the new label scheme
   [\#16612](element-hq/element-web#16612)
 * Remove a couple useless 'use strict' calls
   [\#16650](element-hq/element-web#16650)
 * Remove old conferencing doc
   [\#16648](element-hq/element-web#16648)
 * Bump elliptic from 6.5.3 to 6.5.4
   [\#16644](element-hq/element-web#16644)
 * Add option for audio live streaming
   [\#16604](element-hq/element-web#16604)
 * Update velocity-animate dependency
   [\#16605](element-hq/element-web#16605)
 * Add Edge to the supported tier
   [\#16611](element-hq/element-web#16611)
 * Add multi language spell check
   [\#15851](element-hq/element-web#15851)
 * Document feature_spaces
   [\#16538](element-hq/element-web#16538)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jryans jryans jryans approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@turt2live @jryans