Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Login using fresh account with pending invites fails #8692

Closed
ptman opened this issue Feb 15, 2019 · 5 comments
Closed

Login using fresh account with pending invites fails #8692

ptman opened this issue Feb 15, 2019 · 5 comments
Assignees
Labels
P1 S-Critical Prevents work, causes data loss and/or has no workaround T-Defect

Comments

@ptman
Copy link
Contributor

ptman commented Feb 15, 2019

Description

Riot Web 1.0 log in using fresh account fails.

Steps to reproduce

  • I upgraded riot-web from 0.17.9 to 1.0.0
  • Also updated synapse to 0.99.1.1
  • Old sessions keep working
  • Old users can sign in
  • User freshly created with register_new_matrix_user fails to log in

Log: not sent, don't get that far

Browser console (a bit sanitized for private info):

Now tracking device list for @user:domain.tld
rageshake.js:99 Starting key download for 
["@user:domain.tld"]
rageshake.js:99 MatrixClient sync state => SYNCING
rageshake.js:99 Presence: online
rageshake.js:99 Saving device tracking data at token s13326_215446_22_12261_11907_62_1_667_84
Unread.js:56 Uncaught TypeError: e.getEventReadUpTo is not a function
    at Object.doesRoomHaveUnreadMessages (Unread.js:56)
    at Object.makeRoomTile (RoomSubList.js:188)
    at Array.map (<anonymous>)
    at t.value (LazyRenderList.js:120)
    at l._renderValidatedComponentWithoutOwnerOrContext (ReactCompositeComponent.js:796)
    at l._renderValidatedComponent (ReactCompositeComponent.js:819)
    at l.performInitialMount (ReactCompositeComponent.js:359)
    at l.mountComponent (ReactCompositeComponent.js:255)
    at Object.mountComponent (ReactReconciler.js:43)
    at X.mountChildren (ReactMultiChild.js:234)
    at X._createInitialChildren (ReactDOMComponent.js:701)
    at X.mountComponent (ReactDOMComponent.js:520)
    at Object.mountComponent (ReactReconciler.js:43)
    at X.mountChildren (ReactMultiChild.js:234)
    at X._createInitialChildren (ReactDOMComponent.js:701)
    at X.mountComponent (ReactDOMComponent.js:520)
ReactDOMComponentTree.js:111 Uncaught TypeError: Cannot read property '__reactInternalInstance$acy84h28mye' of null
    at Object.p [as getClosestInstanceFromNode] (ReactDOMComponentTree.js:111)
    at f (ReactEventListener.js:36)
    at p (ReactEventListener.js:65)
    at u.perform (Transaction.js:141)
    at Object.batchedUpdates (ReactDefaultBatchingStrategy.js:60)
    at Object.batchedUpdates (ReactUpdates.js:95)
    at dispatchEvent (ReactEventListener.js:145)
indexeddb-local-backend.js:488 Persisting sync data up to  s13326_215446_22_12261_11907_62_1_667_84
rageshake.js:99 Looking for queued outgoing room key requests
ReactDOMComponentTree.js:111 Uncaught TypeError: Cannot read property '__reactInternalInstance$acy84h28mye' of null
    at Object.p [as getClosestInstanceFromNode] (ReactDOMComponentTree.js:111)
    at f (ReactEventListener.js:36)
    at p (ReactEventListener.js:65)
    at u.perform (Transaction.js:141)
    at Object.batchedUpdates (ReactDefaultBatchingStrategy.js:60)
    at Object.batchedUpdates (ReactUpdates.js:95)
    at dispatchEvent (ReactEventListener.js:145)
rageshake.js:99 No more outgoing room key requests
ReactDOMComponentTree.js:111 Uncaught TypeError: Cannot read property '__reactInternalInstance$acy84h28mye' of null
    at Object.p [as getClosestInstanceFromNode] (ReactDOMComponentTree.js:111)
    at f (ReactEventListener.js:36)
    at p (ReactEventListener.js:65)
    at u.perform (Transaction.js:141)
    at Object.batchedUpdates (ReactDefaultBatchingStrategy.js:60)
    at Object.batchedUpdates (ReactUpdates.js:95)
    at dispatchEvent (ReactEventListener.js:145)
ReactCompositeComponent.js:742 Uncaught TypeError: Cannot read property '_currentElement' of null
    at l._updateRenderedComponent (ReactCompositeComponent.js:742)
    at l._performComponentUpdate (ReactCompositeComponent.js:721)
    at l.updateComponent (ReactCompositeComponent.js:642)
    at l.receiveComponent (ReactCompositeComponent.js:544)
    at Object.receiveComponent (ReactReconciler.js:122)
    at Object.updateChildren (ReactChildReconciler.js:107)
    at X._reconcilerUpdateChildren (ReactMultiChild.js:209)
    at X._updateChildren (ReactMultiChild.js:308)
    at X.updateChildren (ReactMultiChild.js:295)
    at X._updateDOMChildren (ReactDOMComponent.js:944)
    at X.updateComponent (ReactDOMComponent.js:758)
    at X.receiveComponent (ReactDOMComponent.js:720)
    at Object.receiveComponent (ReactReconciler.js:122)
    at Object.updateChildren (ReactChildReconciler.js:107)
    at X._reconcilerUpdateChildren (ReactMultiChild.js:209)
    at X._updateChildren (ReactMultiChild.js:308)
rageshake.js:99 got keys for @user:domain.tld
{YXVSXCBBNW: {…}, DWATWHPULM: {…}, OSBZOLQZFZ: {…}, PPDWEWLHZA: {…}, YLXHSQZALQ: {…}, …}
rageshake.js:99 Completed key download for @user:domain.tld
rageshake.js:99 Device list for @user:domain.tld now up to date
rageshake.js:99 Saving device tracking data at token s13326_215446_22_12261_11907_62_1_667_84

Version information

  • Platform: web
  • Browser: Firefox, Chrome
  • OS: Linux
  • URL: Private instance, riot 1.0.0, config.json sets default home server
@bwindels bwindels self-assigned this Feb 15, 2019
@ptman
Copy link
Contributor Author

ptman commented Feb 15, 2019

So this may have had something to do with invites that I made to the account before first login.

I logged in using riot 0.17.9 and accepted the invites. After that login succeeded.

@ptman ptman changed the title Login using fresh account fails Login using fresh account with pending invites fails Feb 15, 2019
@bwindels
Copy link
Contributor

Thanks for the report!
Did you have any community invites by any chance?

@ptman
Copy link
Contributor Author

ptman commented Feb 15, 2019

yes, there was also a community invite

@bwindels
Copy link
Contributor

Caused by matrix-org/matrix-react-sdk#2629, making a fix now.

@bwindels
Copy link
Contributor

just released 1.0.1 that should fix this. Please reopen if you still see this.

su-ex added a commit to SchildiChat/element-web that referenced this issue Jun 7, 2022
* Make Lao translation available ([\element-hq#22358](element-hq#22358)). Fixes element-hq#22327.
* Option to disable hardware acceleration on Element Desktop ([\element-hq#22295](element-hq#22295)). Contributed by @novocaine.
* Configure custom home.html via `.well-known/matrix/client["io.element.embedded_pages"]["home_url"]` for all your element-web/desktop users ([\element-hq#7790](matrix-org/matrix-react-sdk#7790)). Contributed by @johannes-krude.
* Live location sharing - open location in OpenStreetMap ([\element-hq#8695](matrix-org/matrix-react-sdk#8695)). Contributed by @kerryarchibald.
* Show a dialog when Jitsi encounters an error ([\element-hq#8701](matrix-org/matrix-react-sdk#8701)). Fixes element-hq#22284.
* Add support for setting the `avatar_url` of widgets by integration managers. ([\element-hq#8550](matrix-org/matrix-react-sdk#8550)). Contributed by @Fox32.
* Add an option to ignore (block) a user when reporting their events ([\element-hq#8471](matrix-org/matrix-react-sdk#8471)).
* Add the option to disable hardware acceleration ([\element-hq#8655](matrix-org/matrix-react-sdk#8655)). Contributed by @novocaine.
* Slightly better presentation of read receipts to screen reader users ([\element-hq#8662](matrix-org/matrix-react-sdk#8662)). Fixes element-hq#22293. Contributed by @pvagner.
* Add jump to related event context menu item ([\element-hq#6775](matrix-org/matrix-react-sdk#6775)). Fixes element-hq#19883.
* Add public room directory hook ([\element-hq#8626](matrix-org/matrix-react-sdk#8626)).
* Stop Jitsi if we time out while connecting to a video room ([\element-hq#22301](element-hq#22301)). Fixes element-hq#22283.
* Remove inline margin from UTD error message inside a reply tile on ThreadView ([\element-hq#8708](matrix-org/matrix-react-sdk#8708)). Fixes element-hq#22376. Contributed by @luixxiul.
* Move unread notification dots of the threads list to the expected position ([\element-hq#8700](matrix-org/matrix-react-sdk#8700)). Fixes element-hq#22350. Contributed by @luixxiul.
* Prevent overflow of grid items on a bubble with UTD generally ([\element-hq#8697](matrix-org/matrix-react-sdk#8697)). Contributed by @luixxiul.
* Create 'Unable To Decrypt' grid layout for hidden events on a bubble layout ([\element-hq#8704](matrix-org/matrix-react-sdk#8704)). Fixes element-hq#22365. Contributed by @luixxiul.
* Fix - AccessibleButton does not set disabled attribute ([\element-hq#8682](matrix-org/matrix-react-sdk#8682)). Contributed by @kerryarchibald.
* Fix font not resetting when logging out ([\element-hq#8670](matrix-org/matrix-react-sdk#8670)). Fixes element-hq#17228.
* Fix local aliases section of room settings not working for some homeservers (ie ([\element-hq#8698](matrix-org/matrix-react-sdk#8698)). Fixes element-hq#22337.
* Align EventTile_line with display name on message bubble ([\element-hq#8692](matrix-org/matrix-react-sdk#8692)). Fixes element-hq#22343. Contributed by @luixxiul.
* Convert references to direct chat -> direct message ([\element-hq#8694](matrix-org/matrix-react-sdk#8694)). Contributed by @novocaine.
* Improve combining diacritics for U+20D0 to U+20F0 in Chrome ([\element-hq#8687](matrix-org/matrix-react-sdk#8687)).
* Make the empty thread panel fill BaseCard ([\element-hq#8690](matrix-org/matrix-react-sdk#8690)). Fixes element-hq#22338. Contributed by @luixxiul.
* Fix edge case around composer handling gendered facepalm emoji ([\element-hq#8686](matrix-org/matrix-react-sdk#8686)).
* Fix a grid blowout due to nowrap displayName on a bubble with UTD ([\element-hq#8688](matrix-org/matrix-react-sdk#8688)). Fixes element-hq#21914. Contributed by @luixxiul.
* Apply the same max-width to image tile on the thread timeline as message bubble ([\element-hq#8669](matrix-org/matrix-react-sdk#8669)). Fixes element-hq#22313. Contributed by @luixxiul.
* Fix dropdown button size for picture-in-picture CallView ([\element-hq#8680](matrix-org/matrix-react-sdk#8680)). Fixes element-hq#22316. Contributed by @luixxiul.
* Live location sharing - fix square border for image-less avatar (PSF-1052) ([\element-hq#8679](matrix-org/matrix-react-sdk#8679)). Contributed by @kerryarchibald.
* Stop connecting to a video room if the widget messaging disappears ([\element-hq#8660](matrix-org/matrix-react-sdk#8660)).
* Fix file button and audio player overflowing from message bubble ([\element-hq#8666](matrix-org/matrix-react-sdk#8666)). Fixes element-hq#22308. Contributed by @luixxiul.
* Don't show broken composer format bar when selection is whitespace ([\element-hq#8673](matrix-org/matrix-react-sdk#8673)). Fixes element-hq#10788.
* Fix media upload http 413 handling ([\element-hq#8674](matrix-org/matrix-react-sdk#8674)).
* Fix emoji picker for editing thread responses ([\element-hq#8671](matrix-org/matrix-react-sdk#8671)). Fixes matrix-org/element-web-rageshakes#13129.
* Map attribution while sharing live location is now visible ([\element-hq#8621](matrix-org/matrix-react-sdk#8621)). Fixes element-hq#22236. Contributed by @weeman1337.
* Fix info tile overlapping the time stamp on TimelineCard ([\element-hq#8639](matrix-org/matrix-react-sdk#8639)). Fixes element-hq#22256. Contributed by @luixxiul.
* Fix position of wide images on IRC / modern layout ([\element-hq#8667](matrix-org/matrix-react-sdk#8667)). Fixes element-hq#22309. Contributed by @luixxiul.
* Fix other user's displayName being wrapped on the bubble message layout ([\element-hq#8456](matrix-org/matrix-react-sdk#8456)). Fixes element-hq#22004. Contributed by @luixxiul.
* Set spacing declarations to elements in mx_EventTile_mediaLine ([\element-hq#8665](matrix-org/matrix-react-sdk#8665)). Fixes element-hq#22307. Contributed by @luixxiul.
* Fix wide image overflowing from the thumbnail container ([\element-hq#8663](matrix-org/matrix-react-sdk#8663)). Fixes element-hq#22303. Contributed by @luixxiul.
* Fix styles of "Show all" link button on ReactionsRow ([\element-hq#8658](matrix-org/matrix-react-sdk#8658)). Fixes element-hq#22300. Contributed by @luixxiul.
* Automatically log in after registration ([\element-hq#8654](matrix-org/matrix-react-sdk#8654)). Fixes element-hq#19305. Contributed by @justjanne.
* Fix offline status in window title not working reliably ([\element-hq#8656](matrix-org/matrix-react-sdk#8656)).
* Align input area with event body's first letter in a thread on IRC/modern layout ([\element-hq#8636](matrix-org/matrix-react-sdk#8636)). Fixes element-hq#22252. Contributed by @luixxiul.
* Fix crash on null idp for SSO buttons ([\element-hq#8650](matrix-org/matrix-react-sdk#8650)). Contributed by @hughns.
* Don't open the regular browser or our context menu on right-clicking the `Options` button in the message action bar ([\element-hq#8648](matrix-org/matrix-react-sdk#8648)). Fixes element-hq#22279.
* Show notifications even when Element is focused ([\element-hq#8590](matrix-org/matrix-react-sdk#8590)). Contributed by @sumnerevans.
* Remove padding from the buttons on edit message composer of a event tile on a thread ([\element-hq#8632](matrix-org/matrix-react-sdk#8632)). Contributed by @luixxiul.
* ensure metaspace changes correctly notify listeners ([\element-hq#8611](matrix-org/matrix-react-sdk#8611)). Fixes element-hq#21006. Contributed by @justjanne.
* Hide image banner on stickers, they have a tooltip already ([\element-hq#8641](matrix-org/matrix-react-sdk#8641)). Fixes element-hq#22244.
* Adjust EditMessageComposer style declarations ([\element-hq#8631](matrix-org/matrix-react-sdk#8631)). Fixes element-hq#22231. Contributed by @luixxiul.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 S-Critical Prevents work, causes data loss and/or has no workaround T-Defect
Projects
None yet
Development

No branches or pull requests

3 participants