Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decide if drag&drop room lists should come back #8614

Open
turt2live opened this issue Feb 14, 2019 · 18 comments
Open

Decide if drag&drop room lists should come back #8614

turt2live opened this issue Feb 14, 2019 · 18 comments
Labels
A-Room-List O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Enhancement X-Needs-Design

Comments

@turt2live
Copy link
Member

Currently we don't support dragging rooms between tags on the redesign. We should either support it or rip out all the code which supports it.

@Cadair
Copy link

Cadair commented Feb 14, 2019

+1 to bringing it back

@turt2live
Copy link
Member Author

(before we end up with a billion +1 comments, please use github reactions on the top comment instead)

@jimmycuadra
Copy link

Is there another way to reorder rooms within the same section? I used to use drag and drop to do this. It's not clear from the description if there's another way to do this or whether it's currently impossible in the redesign.

@ara4n
Copy link
Member

ara4n commented Feb 17, 2019

currently impossible; workaround is to use https://tags.t2bot.io

@lampholder
Copy link
Member

Discussing this with Nad and Amandine yesterday - we're all keen for drag and drop to come back if we can guarantee that we will execute and maintain it well.

If we do it, I want us to do it so that:

  • it has finely tuned heuristics to avoid accidental drag and drop
  • it defends against the state changing underneath you mid drag
  • it defends against the state changing just before you drag
  • it works well in all browsers
  • it does not introduce any performance regressions
  • it supports undo to avoid making mistakes that are hard to correct
  • it has a sophisticated local echo awareness so that any changes made via drag and drop don't glitch back and forth
  • it can feedback to the user if whatever changes you made don't end up being persisted remotely for whatever reason

My personal bias is that we implement our UX such that it works stably and well without drag and drop, and then once that solid baseline is in place, consider then whether it's worth the additional investment to add a robust dnd layer on top.

@alphapapa
Copy link

This issue seems relevant: #8723 It claims that a "labs" setting exists to re-enable room user-tags, but I can't find such a labs setting.

Please bring back this feature. I used it extensively to group related rooms. Now they're all in one big "rooms" group, which is useless to me.

@jryans
Copy link
Collaborator

jryans commented Mar 26, 2019

This issue seems relevant: #8723 It claims that a "labs" setting exists to re-enable room user-tags, but I can't find such a labs setting.

(As mentioned in #8723, it's available on https://riot.im/develop only at the moment.)

@JesseNaranjo
Copy link

@lampholder #8614 (comment)
If we do it, I want us to do it so that:
...
* it supports undo to avoid making mistakes that are hard to correct
...

I agree with everything on the list, except the "undo" line. I think undo in a drag-n-drop situation should be fairly easy to do manually - especially if you can only drag one item at a time.

I am not opposed to the undo feature, but if implementing "drag-n-drop undo" requirement is a big hurdle, I would rather see everything else implemented without this.

@alphapapa
Copy link

  • it has finely tuned heuristics to avoid accidental drag and drop
  • it defends against the state changing underneath you mid drag
  • it defends against the state changing just before you drag
  • it works well in all browsers
  • it does not introduce any performance regressions
  • it supports undo to avoid making mistakes that are hard to correct
  • it has a sophisticated local echo awareness so that any changes made via drag and drop don't glitch back and forth
  • it can feedback to the user if whatever changes you made don't end up being persisted remotely for whatever reason

I don't think any features in any software I've used fulfill that list of requirements. For example, file managers don't have finely tuned heuristics to avoid accidental drag and drop, and that's in a context where such accidents could cause data loss.

We're talking about room tags here. The worst that could happen is that a user would have to drag and drop a room into a tag again.

@swedneck
Copy link

Perhaps one option could be to make the order lockable from the settings? I at least don't want to re-order my rooms very often, and would be fine with having to untick an option to be able to re-order them and then re-tick the option.

@BloodyIron
Copy link

I'm in favour of click and dragging between sections, such as 1:1 or rooms to favourites, etc. Like, that's just so convenient, why not have it? IMO

@turt2live
Copy link
Member Author

I've closed/linked a bunch of issues above in favour of this one. If/when we do bring the feature back, the above issues should be considered.

@BloodyIron
Copy link

Drag & Drop stuff is always welcome!

@Flam3z
Copy link

Flam3z commented Nov 17, 2021

+1 dragging and dropping makes organizing so much more easier.

@ahayes
Copy link

ahayes commented Jan 28, 2022

(before we end up with a billion +1 comments, please use github reactions on the top comment instead)

That could work if there was a single clear question to react to. I would like to give a +1 to supporting drag and drop and a -1 to ripping that support out.

I would also like to be able to drag a room between spaces because I'm sure that somehow in the past I have had success in getting People (DM rooms?) from home into spaces, but by default they always seem to get created in home, even if I used a space's People + button to start a new chat.

@t3chguy t3chguy added S-Minor Impairs non-critical functionality or suitable workarounds exist O-Occasional Affects or can be seen by some users regularly or most users rarely labels Oct 17, 2022
@paboum
Copy link

paboum commented Dec 5, 2022

Definitely it would help to sort rooms inside a space in other ways than alphabetically and drag-n-dropping them between spaces.

@forrestwilkins
Copy link

Has there been any progress made for this issue since 2022? I'd love to see this feature brought back.

@t3chguy
Copy link
Member

t3chguy commented Dec 17, 2023

Dragging between sections would likely be desirable, dragging to specify a manual sort order is unlikely desirable with Product

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Room-List O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Enhancement X-Needs-Design
Projects
None yet
Development

No branches or pull requests