Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to send a message sometimes #4580

Closed
lukebarnard1 opened this issue Jul 14, 2017 · 4 comments
Closed

Unable to send a message sometimes #4580

lukebarnard1 opened this issue Jul 14, 2017 · 4 comments
Labels
P2 S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect

Comments

@lukebarnard1
Copy link
Contributor

lukebarnard1 commented Jul 14, 2017

Repro steps:

  • Focus empty composer
  • ctrl + j
  • Hit Enter any number of times
  • Observe the message not being sent.

Related: #4535

@lampholder
Copy link
Member

It seems to go into the same 'code editing' mode as it does when it's in RTE mode. So I think:

  • there's a bug where ctrl + j does anything when you're in markdown mode
  • there's a bug where the UX whilst you're in code editing mode should be improved to make it:
    • obvious that carriage returns are not going to send the message (they're part of the code block)
    • obvious how you return to 'normal mode' to actually send the message

@lampholder lampholder added T-Defect type:rte S-Major Severely degrades major functionality or product features, with no satisfactory workaround P2 labels Jul 17, 2017
@lukebarnard1
Copy link
Contributor Author

I think the second bullet point there is essentially fixing #4535. I've certainly never heard of that particular key combination but apparently some browsers use it for opening dev tools and given we have special treatment for ctrl+i, I'd happily get rid of it.

@lukebarnard1
Copy link
Contributor Author

lukebarnard1 commented Jul 18, 2017

@ara4n
Copy link
Member

ara4n commented Jul 16, 2018

fixed in matrix-org/matrix-react-sdk#1890

@ara4n ara4n closed this as completed Jul 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2 S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect
Projects
None yet
Development

No branches or pull requests

3 participants