Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

If RoomSubList is collapsed or filtered we still don't see the IncomingCallBox for incoming calls(!) #4369

Closed
ara4n opened this issue Jun 20, 2017 · 7 comments
Closed

If RoomSubList is collapsed or filtered we still don't see the IncomingCallBox for incoming calls(!) #4369

ara4n opened this issue Jun 20, 2017 · 7 comments
Assignees
@turt2live
Labels
P1 S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect

Comments

@ara4n
Copy link
Member

ara4n commented Jun 20, 2017

No description provided.

@lampholder lampholder added T-Defect S-Minor Impairs non-critical functionality or suitable workarounds exist P1 ui/ux labels Jun 21, 2017
@lampholder
Copy link
Member

Does this need a design before a fix can be done?

@lampholder lampholder added design X-Needs-Info This issue is blocked awaiting information from the reporter labels Jun 21, 2017
@ara4n
Copy link
Member Author

ara4n commented Jun 21, 2017

No. The problem is simply that the IncomingCallBox has ended up in the wrong place in the DOM yet again, which means that if the RoomSubList is collapsed it's invisible. It also means the CSS is wrong, as it looks like it's embedded within the H2 tag of the list or something.

@dbkr: i assume this is because of a revert fail when demerging my RoomList fixes.

@ara4n ara4n removed the X-Needs-Info This issue is blocked awaiting information from the reporter label Jun 21, 2017
@ara4n
Copy link
Member Author

ara4n commented Jun 21, 2017 •
edited
Loading

this is at least a major bug, because it means people miss calls entirely and screws my demos.

@ara4n ara4n added S-Major Severely degrades major functionality or product features, with no satisfactory workaround and removed design S-Minor Impairs non-critical functionality or suitable workarounds exist labels Jun 21, 2017
@turt2live turt2live mentioned this issue Oct 27, 2017
Closed
@lukebarnard1
Copy link
Contributor

Ok, this is still true - but the incoming call box is pinned to the RoomSubList header regardless of whether it's collapsed and regardless of whether the LeftPanel itself is collapsed. The position is also slightly off.

@turt2live
Copy link
Member

It's not pretty, but it seems to be visible?
image

@lampholder
Copy link
Member

If the list is filtered it's definitely not there:

screen recording 2018-10-23 at 18 02 59 2018-10-23 18_04_23

Sorry for the crappy gif - it starts with isobelle mctestphone making a (hidden) call to me, which is only revealed when I unfilter my roomlist

@turt2live turt2live self-assigned this Dec 5, 2018
turt2live added a commit to matrix-org/matrix-react-sdk that referenced this issue Dec 6, 2018
@turt2live
Show the IncomingCallBox if the call is for the RoomSubList
ca13130 
Fixes element-hq/element-web#4369

Previously the RoomSubList would filter its list of rooms to verify that the incoming call belongs to it. This causes problems when the sub list is being told some rooms don't exist (ie: the list is filtered). It is trivial for the RoomList to instead track which RoomSubList (tag) it should be handing the call off to so we do that instead now. The RoomSubList trusts that the caller has already filtered it and will render the IncomingCallBox if it has an incoming call.
@turt2live turt2live mentioned this issue Dec 6, 2018
Merged
@turt2live
Copy link
Member

Fixed by matrix-org/matrix-react-sdk#2333 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@turt2live turt2live

Labels
P1 S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@turt2live @ara4n @lampholder @lukebarnard1