Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trying to accept invite from @babolivier fails silently #4307

Closed
lukebarnard1 opened this issue Jun 14, 2017 · 3 comments
Closed

Trying to accept invite from @babolivier fails silently #4307

lukebarnard1 opened this issue Jun 14, 2017 · 3 comments
Labels
P1 T-Defect X-Release-Blocker

Comments

@lukebarnard1
Copy link
Contributor

Logs reveal that there was a failed peek into the 1:1 (!frmllkJSfSE...:matrix.org) and the client tried to join another room, weirdly always internal regardless of previously viewed room.
@dbkr
Copy link
Member

dbkr commented Jun 14, 2017

This sounds like #4298

@dbkr
Copy link
Member

dbkr commented Jun 14, 2017

Fixed by matrix-org/matrix-react-sdk#1093

@dbkr dbkr closed this as completed Jun 14, 2017
@lukebarnard1 lukebarnard1 reopened this Jun 14, 2017
@lukebarnard1
Copy link
Contributor Author

@AmandineLP says it's not fixed

lukebarnard1 pushed a commit to matrix-org/matrix-react-sdk that referenced this issue Jun 14, 2017
Attempt to follow closely what RoomView did pre-ILAG
2d6ba05 
In terms of peeking and what happens to the state when joining. This is another attempt to mitigate element-hq/element-web#4307
@ara4n ara4n mentioned this issue Jul 18, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P1 T-Defect X-Release-Blocker
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dbkr @lukebarnard1