Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Say "X removed the room name" instead of showing nothing #4072

Closed
turt2live opened this issue May 30, 2017 · 1 comment
Closed

Say "X removed the room name" instead of showing nothing #4072

turt2live opened this issue May 30, 2017 · 1 comment

Comments

@turt2live
Copy link
Member

Description

image

Hopefully a picture is worth a thousand words. Previously this would say Matthew set the room name to "". however that seems to have lost it's quoting. Matthew removed the room name would probably be better.

Version information

  • Platform: web (in-browser)
  • Browser: Chrome 58
  • OS: Windows 10
  • URL: riot.im/develop
turt2live added a commit to turt2live/matrix-react-sdk that referenced this issue May 30, 2017
@turt2live
Communicate clearly when a room name is set to nothing
1afa464 
Addresses element-hq/element-web#4072

Signed-off-by: Travis Ralston <travpc@gmail.com>
@turt2live turt2live mentioned this issue May 30, 2017
Merged
turt2live added a commit to turt2live/matrix-react-sdk that referenced this issue May 30, 2017
@turt2live
Say "X removed the room name" instead of showing nothing
d9d25e2 
Addresses element-hq/element-web#4072

Signed-off-by: Travis Ralston <travpc@gmail.com>
@turt2live
Copy link
Member Author

Fixed by matrix-org/matrix-react-sdk#958

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@turt2live