Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clearing cache doesn't stop client first #3610

Closed
dbkr opened this issue Apr 11, 2017 · 1 comment
Closed

Clearing cache doesn't stop client first #3610

dbkr opened this issue Apr 11, 2017 · 1 comment

Comments

@dbkr
Copy link
Member

dbkr commented Apr 11, 2017

The 'clear cache & reload' button doesn't stop the client before it nukes all the data, which is normally fine because it reloads the app immediately after, but if for any reason it doesn't (in my case, because of #3597), it will wipe all the data from the store, then next time something comes down the sync stream, get very confused and start emitting spurious new room events, etc., which can also caused data loss because it decided I had no m.direct event and so re-guessed my DM rooms, found none, then replaced my m.direct event with the empty object.

@dbkr
Copy link
Member Author

dbkr commented Apr 11, 2017

This was causing the data loss above in real situations since the indexeddb store waits on a promise while the database is deleted which gives adequate time for a sync response to return.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant