Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Email validation for new account logs me out of my account #22881

Closed
kittykat opened this issue Jul 18, 2022 · 8 comments · Fixed by matrix-org/matrix-react-sdk#9075
Closed

Email validation for new account logs me out of my account #22881

kittykat opened this issue Jul 18, 2022 · 8 comments · Fixed by matrix-org/matrix-react-sdk#9075
Labels
A-3PIDs A-Registration O-Occasional Affects or can be seen by some users regularly or most users rarely S-Critical Prevents work, causes data loss and/or has no workaround T-Defect X-Regression X-Release-Blocker

Comments

@kittykat
Copy link
Contributor

Steps to reproduce

  1. Be logged into Element with an account
  2. In the same browser, click on a validation link for a new Matrix account
  3. Be logged out of your old account and logged into the new one

Outcome

What did you expect?

If I am already logged in, I would expect to not be logged out as that could cause me to lose my keys

What happened instead?

I was logged out and temporarily lost access to my historical messages

Operating system

No response

Browser information

Chromium 101.0.4951.64 (Official Build) Arch Linux (64-bit)

URL for webapp

develop.element.io

Application version

No response

Homeserver

No response

Will you send logs?

No
@germain-gg germain-gg added S-Major Severely degrades major functionality or product features, with no satisfactory workaround O-Uncommon Most users are unlikely to come across this or unexpected workflow labels Jul 18, 2022
@germain-gg
Copy link
Contributor

@kittykat this is marked as a regression, is that how this used to work?

This issue would benefit from being open on Synapse as this is the piece of the stack that issues those emails and the access token when clicking the link
Will close the ticket here as I am not able to move the issue cross organisations

@turt2live
Copy link
Member

@gsouquet this works on app but not staging or develop - considering it a release blocker.

(we also have a code flow that is specifically meant to prevent this from happening on the client side)

@turt2live turt2live reopened this Jul 18, 2022
@turt2live
Copy link
Member

This appears to have regressed by matrix-org/matrix-react-sdk#8654 - we have the code here to prevent the overwrite, but the PR seems to bypass this.

Keeping as a release blocker, but not necessarily for the current RC->release cycle. This is something which needs to be fixed soon, I think, given it's been an issue for a couple months and release blockers are the current way of making that happen (unless there's a different process?)

@turt2live turt2live added S-Critical Prevents work, causes data loss and/or has no workaround Team: Delight and removed S-Major Severely degrades major functionality or product features, with no satisfactory workaround labels Jul 18, 2022
@turt2live
Copy link
Member

critical because it overwrites your account with no warning, causing data loss.

@turt2live turt2live added Team: Delight A-Registration A-3PIDs O-Occasional Affects or can be seen by some users regularly or most users rarely and removed Team: Delight O-Uncommon Most users are unlikely to come across this or unexpected workflow labels Jul 18, 2022
@turt2live
Copy link
Member

also ftr, this is broken on app too (having re-tested myself).

@justjanne justjanne mentioned this issue Jul 19, 2022
Merged
@t3chguy
Copy link
Member

t3chguy commented Jul 19, 2022

@turt2live so is it a regression & release blocker?

@turt2live
Copy link
Member

@t3chguy yes, but not necessarily for this release:

Keeping as a release blocker, but not necessarily for the current RC->release cycle. This is something which needs to be fixed soon, I think, given it's been an issue for a couple months and release blockers are the current way of making that happen (unless there's a different process?)

@t3chguy
Copy link
Member

t3chguy commented Jul 19, 2022

This is something which needs to be fixed soon, I think, given it's been an issue for a couple months and release blockers are the current way of making that happen (unless there's a different process?)

No they really are not, a release blocker stops the release which introduces this behaviour if applicable or the very next one. This should just be prioritised using S-Critical and O- whatever

@justjanne justjanne mentioned this issue Jul 21, 2022
Closed
su-ex added a commit to SchildiChat/element-desktop that referenced this issue Aug 22, 2022
@su-ex
Merge tag 'v1.11.2' into sc
2996b7b 
* Live location share -  focus on user location on list item click ([\#9051](matrix-org/matrix-react-sdk#9051)). Contributed by @kerryarchibald.
* Live location sharing - don't trigger unread counts for beacon location events ([\#9071](matrix-org/matrix-react-sdk#9071)). Contributed by @kerryarchibald.
* Support for sending voice messages as replies and in threads ([\#9097](matrix-org/matrix-react-sdk#9097)). Fixes element-hq/element-web#22031.
* Add `Reply in thread` button to the right-click message context-menu ([\#9004](matrix-org/matrix-react-sdk#9004)). Fixes element-hq/element-web#22745.
* Starred_Messages_Feature_Contd_II/Outreachy ([\#9086](matrix-org/matrix-react-sdk#9086)).
* Use "frequently used emojis" for autocompletion in composer ([\#8998](matrix-org/matrix-react-sdk#8998)). Fixes element-hq/element-web#18978. Contributed by @grimhilt.
* Improve clickability of view source event toggle button  ([\#9068](matrix-org/matrix-react-sdk#9068)). Fixes element-hq/element-web#21856. Contributed by @luixxiul.
* Improve clickability of "collapse" link button on bubble layout ([\#9037](matrix-org/matrix-react-sdk#9037)). Fixes element-hq/element-web#22864. Contributed by @luixxiul.
* Starred_Messages_Feature/Outreachy ([\#8842](matrix-org/matrix-react-sdk#8842)).
* Implement Use Case Selection screen ([\#8984](matrix-org/matrix-react-sdk#8984)). Contributed by @justjanne.
* Live location share - handle insufficient permissions in location sharing ([\#9047](matrix-org/matrix-react-sdk#9047)). Contributed by @kerryarchibald.
* Improve _FilePanel.scss ([\#9031](matrix-org/matrix-react-sdk#9031)). Contributed by @luixxiul.
* Improve spotlight accessibility by adding context menus ([\#8907](matrix-org/matrix-react-sdk#8907)). Fixes element-hq/element-web#20875 and element-hq/element-web#22675. Contributed by @justjanne.
* Replace mask-images with svg components in MessageActionBar ([\#9088](matrix-org/matrix-react-sdk#9088)). Fixes element-hq/element-web#22912. Contributed by @kerryarchibald.
* Unbreak in-app permalink tooltips ([\#9087](matrix-org/matrix-react-sdk#9087)). Fixes element-hq/element-web#22874.
* Show a back button when viewing a space member ([\#9095](matrix-org/matrix-react-sdk#9095)). Fixes element-hq/element-web#22898.
* Align the right edge of info tile lines with normal ones on IRC layout ([\#9058](matrix-org/matrix-react-sdk#9058)). Fixes element-hq/element-web#22871. Contributed by @luixxiul.
* Prevent email verification from overriding existing sessions ([\#9075](matrix-org/matrix-react-sdk#9075)). Fixes element-hq/element-web#22881. Contributed by @justjanne.
* Fix wrong buttons being used when exploring public rooms ([\#9062](matrix-org/matrix-react-sdk#9062)). Fixes element-hq/element-web#22862.
* Re-add padding to generic event list summary on IRC layout ([\#9063](matrix-org/matrix-react-sdk#9063)). Fixes element-hq/element-web#22869. Contributed by @luixxiul.
* Joining federated rooms via the spotlight search should no longer cause a "No known servers" error. ([\#9055](matrix-org/matrix-react-sdk#9055)). Fixes element-hq/element-web#22845. Contributed by @Half-Shot.
su-ex added a commit to SchildiChat/matrix-react-sdk that referenced this issue Aug 22, 2022
@su-ex
Merge tag 'v3.51.0' into sc
8cb2754 
* Live location share -  focus on user location on list item click ([\matrix-org#9051](matrix-org#9051)). Contributed by @kerryarchibald.
* Live location sharing - don't trigger unread counts for beacon location events ([\matrix-org#9071](matrix-org#9071)). Contributed by @kerryarchibald.
* Support for sending voice messages as replies and in threads ([\matrix-org#9097](matrix-org#9097)). Fixes element-hq/element-web#22031.
* Add `Reply in thread` button to the right-click message context-menu ([\matrix-org#9004](matrix-org#9004)). Fixes element-hq/element-web#22745.
* Starred_Messages_Feature_Contd_II/Outreachy ([\matrix-org#9086](matrix-org#9086)).
*  Use "frequently used emojis" for autocompletion in composer ([\matrix-org#8998](matrix-org#8998)). Fixes element-hq/element-web#18978. Contributed by @grimhilt.
* Improve clickability of view source event toggle button  ([\matrix-org#9068](matrix-org#9068)). Fixes element-hq/element-web#21856. Contributed by @luixxiul.
* Improve clickability of "collapse" link button on bubble layout ([\matrix-org#9037](matrix-org#9037)). Fixes element-hq/element-web#22864. Contributed by @luixxiul.
* Starred_Messages_Feature/Outreachy ([\matrix-org#8842](matrix-org#8842)).
* Implement Use Case Selection screen ([\matrix-org#8984](matrix-org#8984)). Contributed by @justjanne.
* Live location share - handle insufficient permissions in location sharing ([\matrix-org#9047](matrix-org#9047)). Contributed by @kerryarchibald.
* Improve _FilePanel.scss ([\matrix-org#9031](matrix-org#9031)). Contributed by @luixxiul.
* Improve spotlight accessibility by adding context menus ([\matrix-org#8907](matrix-org#8907)). Fixes element-hq/element-web#20875 and element-hq/element-web#22675. Contributed by @justjanne.
* Replace mask-images with svg components in MessageActionBar ([\matrix-org#9088](matrix-org#9088)). Fixes element-hq/element-web#22912. Contributed by @kerryarchibald.
* Unbreak in-app permalink tooltips ([\matrix-org#9087](matrix-org#9087)). Fixes element-hq/element-web#22874.
* Show a back button when viewing a space member ([\matrix-org#9095](matrix-org#9095)). Fixes element-hq/element-web#22898.
* Align the right edge of info tile lines with normal ones on IRC layout ([\matrix-org#9058](matrix-org#9058)). Fixes element-hq/element-web#22871. Contributed by @luixxiul.
* Prevent email verification from overriding existing sessions ([\matrix-org#9075](matrix-org#9075)). Fixes element-hq/element-web#22881. Contributed by @justjanne.
* Fix wrong buttons being used when exploring public rooms ([\matrix-org#9062](matrix-org#9062)). Fixes element-hq/element-web#22862.
* Re-add padding to generic event list summary on IRC layout ([\matrix-org#9063](matrix-org#9063)). Fixes element-hq/element-web#22869. Contributed by @luixxiul.
* Joining federated rooms via the spotlight search should no longer cause a "No known servers" error. ([\matrix-org#9055](matrix-org#9055)). Fixes element-hq/element-web#22845. Contributed by @Half-Shot.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-3PIDs A-Registration O-Occasional Affects or can be seen by some users regularly or most users rarely S-Critical Prevents work, causes data loss and/or has no workaround T-Defect X-Regression X-Release-Blocker
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Prevent email verification from overriding existing sessions matrix-org/matrix-react-sdk
4 participants
@kittykat @germain-gg @turt2live @t3chguy