Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Waveform overflows from audio player #22604

Closed
luixxiul opened this issue Jun 17, 2022 · 5 comments · Fixed by matrix-org/matrix-react-sdk#8861
Closed

Waveform overflows from audio player #22604

luixxiul opened this issue Jun 17, 2022 · 5 comments · Fixed by matrix-org/matrix-react-sdk#8861
Labels
A-IRC-Layout A-Voice-Messages O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect

Comments

@luixxiul
Copy link

Steps to reproduce

  1. Enable IRC layout and open the thread to reduce the width of the UI
  2. Upload an audio file

Outcome

What did you expect?

The waveform should not overflow.

after

What happened instead?

It overflows.

before

Operating system

Debian

Browser information

Firefox ESR 91

URL for webapp

localhost

Application version

develop branch

Homeserver

No response

Will you send logs?

No

@DoM1niC
Copy link

DoM1niC commented Jun 17, 2022

grafik
the Font-Size do similar the same like your Issue

your new PR fixed my Problem THX matrix-org/matrix-react-sdk#8861

@luixxiul
Copy link
Author

@DoM1niC Leider hier gibt es mir nix mehr zu tun weil das Design des Spielern von offiziellen Mitgliedern festgestellt und entwickelt werden soll.

@weeman1337
Copy link
Contributor

Leider hier gibt es mir nix mehr zu tun weil das Design des Spielern von offiziellen Mitgliedern festgestellt und entwickelt werden soll.

Translating: Nothing else to do here because these parts of the app should go through the design process.

@DoM1niC if you encounter any other issue can you please open an issue for that?

@DoM1niC
Copy link

DoM1niC commented Jun 17, 2022

In my case I merged his PR in my own Fork and all is fine 🙌🏻

@duxovni duxovni added S-Minor Impairs non-critical functionality or suitable workarounds exist A-IRC-Layout A-Voice-Messages O-Uncommon Most users are unlikely to come across this or unexpected workflow labels Jun 17, 2022
@luixxiul
Copy link
Author

@DoM1niC ah I understood what you have wanted to say :-D

su-ex added a commit to SchildiChat/element-desktop that referenced this issue Mar 15, 2023
* Remove experimental PWA support for Firefox and Safari ([\#24630](element-hq/element-web#24630)).
* Only allow to start a DM with one email if encryption by default is enabled ([\#10253](matrix-org/matrix-react-sdk#10253)). Fixes element-hq/element-web#23133.
* DM rooms are now encrypted if encryption by default is enabled and only inviting a single email address. Any action in the result DM room will be blocked until the other has joined. ([\#10229](matrix-org/matrix-react-sdk#10229)).
* Reduce bottom margin of ReplyChain on compact modern layout ([\#8972](matrix-org/matrix-react-sdk#8972)). Fixes element-hq/element-web#22748. Contributed by @luixxiul.
* Support for v2 of MSC3903 ([\#10165](matrix-org/matrix-react-sdk#10165)). Contributed by @hughns.
* When starting a DM, existing rooms with pending third-party invites will be reused. ([\#10256](matrix-org/matrix-react-sdk#10256)). Fixes element-hq/element-web#23139.
* Polls push rules: synchronise poll rules with message rules ([\#10263](matrix-org/matrix-react-sdk#10263)). Contributed by @kerryarchibald.
* New verification request toast button labels ([\#10259](matrix-org/matrix-react-sdk#10259)).
* Remove padding around integration manager iframe ([\#10148](matrix-org/matrix-react-sdk#10148)).
* Fix block code styling in rich text editor ([\#10246](matrix-org/matrix-react-sdk#10246)). Contributed by @alunturner.
* Poll history: fetch more poll history ([\#10235](matrix-org/matrix-react-sdk#10235)). Contributed by @kerryarchibald.
* Sort short/exact emoji matches before longer incomplete matches ([\#10212](matrix-org/matrix-react-sdk#10212)). Fixes element-hq/element-web#23210. Contributed by @grimhilt.
* Poll history: detail screen ([\#10172](matrix-org/matrix-react-sdk#10172)). Contributed by @kerryarchibald.
* Provide a more detailed error message than "No known servers" ([\#6048](matrix-org/matrix-react-sdk#6048)). Fixes element-hq/element-web#13247. Contributed by @aaronraimist.
* Say when a call was answered from a different device ([\#10224](matrix-org/matrix-react-sdk#10224)).
* Widget permissions customizations using module api ([\#10121](matrix-org/matrix-react-sdk#10121)). Contributed by @maheichyk.
* Fix copy button icon overlapping with copyable text ([\#10227](matrix-org/matrix-react-sdk#10227)). Contributed by @Adesh-Pandey.
* Support joining non-peekable rooms via the module API ([\#10154](matrix-org/matrix-react-sdk#10154)). Contributed by @maheichyk.
* The "new login" toast does now display the same device information as in the settings. "No" does now open the device settings. "Yes, it was me" dismisses the toast. ([\#10200](matrix-org/matrix-react-sdk#10200)).
* Do not prompt for a password when doing a „reset all“ after login ([\#10208](matrix-org/matrix-react-sdk#10208)).
* Fix macOS notarisation using keychain credentials ([\element-hq#557](element-hq#557)).
* Let electron-builder correctly set StartupWMClass ([\element-hq#526](element-hq#526)). Fixes element-hq/element-web#13780.
* Fix incorrect copy in space creation flow ([\#10296](matrix-org/matrix-react-sdk#10296)). Fixes element-hq/element-web#24741.
* Fix space settings dialog having rogue title tooltip ([\#10293](matrix-org/matrix-react-sdk#10293)). Fixes element-hq/element-web#24740.
* Show spinner when starting a DM from the user profile (right panel) ([\#10290](matrix-org/matrix-react-sdk#10290)).
* Reduce height of toggle on expanded view source event ([\#10283](matrix-org/matrix-react-sdk#10283)). Fixes element-hq/element-web#22873. Contributed by @luixxiul.
* Pillify http and non-prefixed matrix.to links ([\#10277](matrix-org/matrix-react-sdk#10277)). Fixes element-hq/element-web#20844.
* Fix some features not being configurable via `features` ([\#10276](matrix-org/matrix-react-sdk#10276)).
* Fix starting a DM from the right panel in some cases ([\#10278](matrix-org/matrix-react-sdk#10278)). Fixes element-hq/element-web#24722.
* Align info EventTile and normal EventTile on IRC layout ([\#10197](matrix-org/matrix-react-sdk#10197)). Fixes element-hq/element-web#22782. Contributed by @luixxiul.
* Fix blowout of waveform of the voice message player on narrow UI ([\#8861](matrix-org/matrix-react-sdk#8861)). Fixes element-hq/element-web#22604. Contributed by @luixxiul.
* Fix the hidden view source toggle on IRC layout ([\#10266](matrix-org/matrix-react-sdk#10266)). Fixes element-hq/element-web#22872. Contributed by @luixxiul.
* Fix buttons on the room header being compressed due to long room name ([\#10155](matrix-org/matrix-react-sdk#10155)). Contributed by @luixxiul.
* Use the room avatar as a placeholder in calls ([\#10231](matrix-org/matrix-react-sdk#10231)).
* Fix calls showing as 'connecting' after hangup ([\#10223](matrix-org/matrix-react-sdk#10223)).
* Prevent multiple Jitsi calls started at the same time ([\#10183](matrix-org/matrix-react-sdk#10183)). Fixes element-hq/element-web#23009.
* Make localization keys compatible with agglutinative and/or SOV type languages ([\#10159](matrix-org/matrix-react-sdk#10159)). Contributed by @luixxiul.
su-ex added a commit to SchildiChat/element-web that referenced this issue Mar 15, 2023
* Remove experimental PWA support for Firefox and Safari ([\element-hq#24630](element-hq#24630)).
* Only allow to start a DM with one email if encryption by default is enabled ([\element-hq#10253](matrix-org/matrix-react-sdk#10253)). Fixes element-hq#23133.
* DM rooms are now encrypted if encryption by default is enabled and only inviting a single email address. Any action in the result DM room will be blocked until the other has joined. ([\element-hq#10229](matrix-org/matrix-react-sdk#10229)).
* Reduce bottom margin of ReplyChain on compact modern layout ([\element-hq#8972](matrix-org/matrix-react-sdk#8972)). Fixes element-hq#22748. Contributed by @luixxiul.
* Support for v2 of MSC3903 ([\element-hq#10165](matrix-org/matrix-react-sdk#10165)). Contributed by @hughns.
* When starting a DM, existing rooms with pending third-party invites will be reused. ([\element-hq#10256](matrix-org/matrix-react-sdk#10256)). Fixes element-hq#23139.
* Polls push rules: synchronise poll rules with message rules ([\element-hq#10263](matrix-org/matrix-react-sdk#10263)). Contributed by @kerryarchibald.
* New verification request toast button labels ([\element-hq#10259](matrix-org/matrix-react-sdk#10259)).
* Remove padding around integration manager iframe ([\#10148](matrix-org/matrix-react-sdk#10148)).
* Fix block code styling in rich text editor ([\element-hq#10246](matrix-org/matrix-react-sdk#10246)). Contributed by @alunturner.
* Poll history: fetch more poll history ([\element-hq#10235](matrix-org/matrix-react-sdk#10235)). Contributed by @kerryarchibald.
* Sort short/exact emoji matches before longer incomplete matches ([\element-hq#10212](matrix-org/matrix-react-sdk#10212)). Fixes element-hq#23210. Contributed by @grimhilt.
* Poll history: detail screen ([\element-hq#10172](matrix-org/matrix-react-sdk#10172)). Contributed by @kerryarchibald.
* Provide a more detailed error message than "No known servers" ([\element-hq#6048](matrix-org/matrix-react-sdk#6048)). Fixes element-hq#13247. Contributed by @aaronraimist.
* Say when a call was answered from a different device ([\element-hq#10224](matrix-org/matrix-react-sdk#10224)).
* Widget permissions customizations using module api ([\element-hq#10121](matrix-org/matrix-react-sdk#10121)). Contributed by @maheichyk.
* Fix copy button icon overlapping with copyable text ([\element-hq#10227](matrix-org/matrix-react-sdk#10227)). Contributed by @Adesh-Pandey.
* Support joining non-peekable rooms via the module API ([\element-hq#10154](matrix-org/matrix-react-sdk#10154)). Contributed by @maheichyk.
* The "new login" toast does now display the same device information as in the settings. "No" does now open the device settings. "Yes, it was me" dismisses the toast. ([\element-hq#10200](matrix-org/matrix-react-sdk#10200)).
* Do not prompt for a password when doing a „reset all“ after login ([\element-hq#10208](matrix-org/matrix-react-sdk#10208)).
* Fix incorrect copy in space creation flow ([\element-hq#10296](matrix-org/matrix-react-sdk#10296)). Fixes element-hq#24741.
* Fix space settings dialog having rogue title tooltip ([\element-hq#10293](matrix-org/matrix-react-sdk#10293)). Fixes element-hq#24740.
* Show spinner when starting a DM from the user profile (right panel) ([\element-hq#10290](matrix-org/matrix-react-sdk#10290)).
* Reduce height of toggle on expanded view source event ([\element-hq#10283](matrix-org/matrix-react-sdk#10283)). Fixes element-hq#22873. Contributed by @luixxiul.
* Pillify http and non-prefixed matrix.to links ([\element-hq#10277](matrix-org/matrix-react-sdk#10277)). Fixes element-hq#20844.
* Fix some features not being configurable via `features` ([\element-hq#10276](matrix-org/matrix-react-sdk#10276)).
* Fix starting a DM from the right panel in some cases ([\element-hq#10278](matrix-org/matrix-react-sdk#10278)). Fixes element-hq#24722.
* Align info EventTile and normal EventTile on IRC layout ([\element-hq#10197](matrix-org/matrix-react-sdk#10197)). Fixes element-hq#22782. Contributed by @luixxiul.
* Fix blowout of waveform of the voice message player on narrow UI ([\element-hq#8861](matrix-org/matrix-react-sdk#8861)). Fixes element-hq#22604. Contributed by @luixxiul.
* Fix the hidden view source toggle on IRC layout ([\element-hq#10266](matrix-org/matrix-react-sdk#10266)). Fixes element-hq#22872. Contributed by @luixxiul.
* Fix buttons on the room header being compressed due to long room name ([\element-hq#10155](matrix-org/matrix-react-sdk#10155)). Contributed by @luixxiul.
* Use the room avatar as a placeholder in calls ([\element-hq#10231](matrix-org/matrix-react-sdk#10231)).
* Fix calls showing as 'connecting' after hangup ([\element-hq#10223](matrix-org/matrix-react-sdk#10223)).
* Prevent multiple Jitsi calls started at the same time ([\element-hq#10183](matrix-org/matrix-react-sdk#10183)). Fixes element-hq#23009.
* Make localization keys compatible with agglutinative and/or SOV type languages ([\element-hq#10159](matrix-org/matrix-react-sdk#10159)). Contributed by @luixxiul.
su-ex added a commit to SchildiChat/matrix-react-sdk that referenced this issue Mar 15, 2023
* Only allow to start a DM with one email if encryption by default is enabled ([\matrix-org#10253](matrix-org#10253)). Fixes element-hq/element-web#23133.
* DM rooms are now encrypted if encryption by default is enabled and only inviting a single email address. Any action in the result DM room will be blocked until the other has joined. ([\matrix-org#10229](matrix-org#10229)).
* Reduce bottom margin of ReplyChain on compact modern layout ([\matrix-org#8972](matrix-org#8972)). Fixes element-hq/element-web#22748. Contributed by @luixxiul.
* Support for v2 of MSC3903 ([\matrix-org#10165](matrix-org#10165)). Contributed by @hughns.
* When starting a DM, existing rooms with pending third-party invites will be reused. ([\matrix-org#10256](matrix-org#10256)). Fixes element-hq/element-web#23139.
* Polls push rules: synchronise poll rules with message rules ([\matrix-org#10263](matrix-org#10263)). Contributed by @kerryarchibald.
* New verification request toast button labels ([\matrix-org#10259](matrix-org#10259)).
* Remove padding around integration manager iframe ([\matrix-org#10148](matrix-org#10148)).
* Fix block code styling in rich text editor ([\matrix-org#10246](matrix-org#10246)). Contributed by @alunturner.
* Poll history: fetch more poll history ([\matrix-org#10235](matrix-org#10235)). Contributed by @kerryarchibald.
* Sort short/exact emoji matches before longer incomplete matches ([\matrix-org#10212](matrix-org#10212)). Fixes element-hq/element-web#23210. Contributed by @grimhilt.
* Poll history: detail screen ([\matrix-org#10172](matrix-org#10172)). Contributed by @kerryarchibald.
* Provide a more detailed error message than "No known servers" ([\matrix-org#6048](matrix-org#6048)). Fixes element-hq/element-web#13247. Contributed by @aaronraimist.
* Say when a call was answered from a different device ([\matrix-org#10224](matrix-org#10224)).
* Widget permissions customizations using module api ([\matrix-org#10121](matrix-org#10121)). Contributed by @maheichyk.
* Fix copy button icon overlapping with copyable text ([\matrix-org#10227](matrix-org#10227)). Contributed by @Adesh-Pandey.
* Support joining non-peekable rooms via the module API ([\matrix-org#10154](matrix-org#10154)). Contributed by @maheichyk.
* The "new login" toast does now display the same device information as in the settings. "No" does now open the device settings. "Yes, it was me" dismisses the toast. ([\matrix-org#10200](matrix-org#10200)).
* Do not prompt for a password when doing a „reset all“ after login ([\matrix-org#10208](matrix-org#10208)).
* Fix incorrect copy in space creation flow ([\matrix-org#10296](matrix-org#10296)). Fixes element-hq/element-web#24741.
* Fix space settings dialog having rogue title tooltip ([\matrix-org#10293](matrix-org#10293)). Fixes element-hq/element-web#24740.
* Show spinner when starting a DM from the user profile (right panel) ([\matrix-org#10290](matrix-org#10290)).
* Reduce height of toggle on expanded view source event ([\matrix-org#10283](matrix-org#10283)). Fixes element-hq/element-web#22873. Contributed by @luixxiul.
* Pillify http and non-prefixed matrix.to links ([\matrix-org#10277](matrix-org#10277)). Fixes element-hq/element-web#20844.
* Fix some features not being configurable via `features` ([\matrix-org#10276](matrix-org#10276)).
* Fix starting a DM from the right panel in some cases ([\matrix-org#10278](matrix-org#10278)). Fixes element-hq/element-web#24722.
* Align info EventTile and normal EventTile on IRC layout ([\matrix-org#10197](matrix-org#10197)). Fixes element-hq/element-web#22782. Contributed by @luixxiul.
* Fix blowout of waveform of the voice message player on narrow UI ([\matrix-org#8861](matrix-org#8861)). Fixes element-hq/element-web#22604. Contributed by @luixxiul.
* Fix the hidden view source toggle on IRC layout ([\matrix-org#10266](matrix-org#10266)). Fixes element-hq/element-web#22872. Contributed by @luixxiul.
* Fix buttons on the room header being compressed due to long room name ([\matrix-org#10155](matrix-org#10155)). Contributed by @luixxiul.
* Use the room avatar as a placeholder in calls ([\matrix-org#10231](matrix-org#10231)).
* Fix calls showing as 'connecting' after hangup ([\matrix-org#10223](matrix-org#10223)).
* Prevent multiple Jitsi calls started at the same time ([\matrix-org#10183](matrix-org#10183)). Fixes element-hq/element-web#23009.
* Make localization keys compatible with agglutinative and/or SOV type languages ([\matrix-org#10159](matrix-org#10159)). Contributed by @luixxiul.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-IRC-Layout A-Voice-Messages O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants