Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When requesting keys from other sessions to attempt to resolve decryption errors, also double-check key backups in 4S #21026

Closed
Tracked by #199
duxovni opened this issue Feb 10, 2022 · 0 comments · Fixed by matrix-org/matrix-js-sdk#2373
Closed
Tracked by #199

When requesting keys from other sessions to attempt to resolve decryption errors, also double-check key backups in 4S #21026

duxovni opened this issue Feb 10, 2022 · 0 comments · Fixed by matrix-org/matrix-js-sdk#2373
Assignees
@duxovni
Labels
T-Task Tasks for the team like planning

Comments

@duxovni
Copy link
Contributor

duxovni commented Feb 10, 2022

May be involved in #20461. Not clear why key backups wouldn't be properly loaded to begin with, and we should still address that if that's the case (maybe matrix-org/matrix-react-sdk#7741 will be able to provide us with more info).
This was referenced Feb 10, 2022
Closed
Closed
@duxovni duxovni self-assigned this Feb 10, 2022
@germain-gg germain-gg added the T-Task Tasks for the team like planning label Feb 11, 2022
@BillCarsonFr BillCarsonFr mentioned this issue Mar 8, 2022
Closed
@duxovni duxovni mentioned this issue May 16, 2022
Merged
su-ex added a commit to SchildiChat/matrix-js-sdk that referenced this issue Jul 7, 2022
@su-ex
Merge tag 'v19.0.0' into sc
2a6db46 
* Remove unused sessionStore ([\matrix-org#2455](matrix-org#2455)).
* Implement MSC3827: Filtering of `/publicRooms` by room type ([\matrix-org#2469](matrix-org#2469)).
* expose latestLocationEvent on beacon model ([\matrix-org#2467](matrix-org#2467)). Contributed by @kerryarchibald.
* Live location share - add start time leniency ([\matrix-org#2465](matrix-org#2465)). Contributed by @kerryarchibald.
* Log real errors and not just their messages, traces are useful ([\matrix-org#2464](matrix-org#2464)).
* Various changes to `src/crypto` files for correctness ([\matrix-org#2137](matrix-org#2137)). Contributed by @ShadowJonathan.
* Update MSC3786 implementation: Check the `state_key` ([\matrix-org#2429](matrix-org#2429)).
* Timeline needs to refresh when we see a MSC2716 marker event  ([\matrix-org#2299](matrix-org#2299)). Contributed by @MadLittleMods.
* Try to load keys from key backup when a message fails to decrypt ([\matrix-org#2373](matrix-org#2373)). Fixes element-hq/element-web#21026. Contributed by @duxovni.
* Send call version `1` as a string ([\matrix-org#2471](matrix-org#2471)). Fixes element-hq/element-web#22629.
* Fix issue with `getEventTimeline` returning undefined for thread roots in main timeline ([\matrix-org#2454](matrix-org#2454)). Fixes element-hq/element-web#22539.
* Add missing `type` property on `IAuthData` ([\matrix-org#2463](matrix-org#2463)).
* Clearly indicate that `lastReply` on a Thread can return falsy ([\matrix-org#2462](matrix-org#2462)).
* Fix issues with getEventTimeline and thread roots ([\matrix-org#2444](matrix-org#2444)). Fixes element-hq/element-web#21613.
* Live location sharing - monitor liveness of beacons yet to start ([\matrix-org#2437](matrix-org#2437)). Contributed by @kerryarchibald.
* Refactor Relations to not be per-EventTimelineSet ([\matrix-org#2412](matrix-org#2412)). Fixes matrix-org#2399 and element-hq/element-web#22298.
* Add tests for sendEvent threadId handling ([\matrix-org#2435](matrix-org#2435)). Fixes element-hq/element-web#22433.
* Make sure `encryptAndSendKeysToDevices` assumes devices are unique per-user. ([\matrix-org#2136](matrix-org#2136)). Fixes matrix-org#2135. Contributed by @ShadowJonathan.
* Don't bug the user while re-checking key backups after decryption failures ([\matrix-org#2430](matrix-org#2430)). Fixes element-hq/element-web#22416. Contributed by @duxovni.
@BillCarsonFr BillCarsonFr mentioned this issue Dec 9, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@duxovni duxovni

Labels
T-Task Tasks for the team like planning
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Try to load keys from key backup when a message fails to decrypt matrix-org/matrix-js-sdk
2 participants
@germain-gg @duxovni