Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New widget load permission prompt #11262

Closed
4 tasks done
turt2live opened this issue Oct 29, 2019 · 3 comments
Closed
4 tasks done

New widget load permission prompt #11262

turt2live opened this issue Oct 29, 2019 · 3 comments
Assignees
@turt2live
Labels
A-Integrations A-Widgets P1 Privacy

Comments

@turt2live
Copy link
Member

turt2live commented Oct 29, 2019 •
edited
Loading

User story: element-hq/user-stories#7

See matrix-org/matrix-react-sdk#3577 and element-hq/riot-meta#311 for details on the setting itself.

Design #11262 (comment). See story for new behaviour.

  • Most of the design
  • Hook up to new setting
  • Context menu on widget title
  • Encryption warning
@turt2live turt2live changed the title Actually hook up the widget load permission dialog to the new setting New widget load permission prompt Nov 8, 2019
@turt2live turt2live added this to the Integration manager closure sprint milestone Nov 8, 2019
@turt2live turt2live added Privacy privacy-sprint and removed feature T-Task Tasks for the team like planning labels Nov 8, 2019
@turt2live turt2live mentioned this issue Nov 8, 2019
Closed
@turt2live turt2live added phase:2 and removed phase:1 labels Nov 8, 2019
@turt2live turt2live removed this from the Integration manager closure sprint milestone Nov 8, 2019
@turt2live turt2live self-assigned this Nov 14, 2019
@turt2live
Copy link
Member Author

https://zpl.io/br0B0qX
image
image

image

turt2live added a commit to matrix-org/matrix-react-sdk that referenced this issue Nov 15, 2019
@turt2live
Implement the bulk of the new widget permission prompt design
6b726a8 
Part 1 of element-hq/element-web#11262

This is all the visual changes - the actual wiring of the UI to the right places is for another PR (though this PR still works independently).

The help icon is known to be weird here - it's a bug in the svg we have. The tooltip also goes right instead of up because making the tooltip go up is not easy work for this PR - maybe a future one if we *really* want it to go up.
@turt2live turt2live mentioned this issue Nov 15, 2019
Merged
turt2live added a commit to matrix-org/matrix-react-sdk that referenced this issue Nov 19, 2019
@turt2live
Wire up the widget permission prompt to the cross-platform setting
b185eed 
This doesn't have any backwards compatibility with anyone who has already clicked "Allow". We kinda want everyone to read the new prompt, so what better way to do it than effectively revoke all widget permissions?

Part of element-hq/element-web#11262
@turt2live turt2live mentioned this issue Nov 19, 2019
Merged
@turt2live
Copy link
Member Author

Context menu mockup that isn't crappy screenshot tooling:
image

@turt2live turt2live mentioned this issue Nov 21, 2019
Merged
turt2live added a commit to matrix-org/matrix-react-sdk that referenced this issue Nov 21, 2019
@turt2live
Move many widget options to a context menu
fd12eb2 
Part of element-hq/element-web#11262
@turt2live turt2live mentioned this issue Nov 21, 2019
Merged
@turt2live
Copy link
Member Author

This happened

@HarHarLinks HarHarLinks mentioned this issue May 16, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@turt2live turt2live

Labels
A-Integrations A-Widgets P1 Privacy
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@turt2live @lampholder