Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Room retention event implementation #7809

Merged
merged 3 commits into from
Jun 14, 2024

Conversation

Velin92
Copy link
Member

@Velin92 Velin92 commented Jun 14, 2024

No description provided.

Copy link

codecov bot commented Jun 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.67%. Comparing base (cf3dcca) to head (ddd97be).
Report is 43 commits behind head on develop.

Current head ddd97be differs from pull request most recent head 05f5519

Please upload reports for the commit 05f5519 to get more accurate results.

Additional details and impacted files
@@             Coverage Diff              @@
##           develop    #7809       +/-   ##
============================================
+ Coverage    12.33%   55.67%   +43.33%     
============================================
  Files         1651      449     -1202     
  Lines       163960    18917   -145043     
  Branches     67314     7964    -59350     
============================================
- Hits         20232    10532     -9700     
+ Misses      143091     8156   -134935     
+ Partials       637      229      -408     
Flag Coverage Δ
uitests 55.67% <ø> (+0.02%) ⬆️
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Jun 14, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@Velin92 Velin92 merged commit 3b776f3 into develop Jun 14, 2024
5 checks passed
@Velin92 Velin92 deleted the mauroromito/room_retention_implementation branch June 14, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants