-
Notifications
You must be signed in to change notification settings - Fork 489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement social login #3890
Implement social login #3890
Conversation
…ed to a social login provider.
…ton and apply dedicated theme if needed.
… buttons according to a given array of SSO Identity Providers.
… and ASWebAuthenticationSession.
…espective parameters.
… get a deep link path at the end.
override func layoutSubviews() { | ||
super.layoutSubviews() | ||
|
||
self.layer.cornerRadius = Constants.cornerRadius |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason for not moving this line into commonInit
?
static let redirectURL = "redirectUrl" | ||
} | ||
|
||
enum Pathes { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a typo on Pathes
public typealias SSOAuthentificationSessionCompletionHandler = (URL?, Error?) -> Void | ||
|
||
/// An interface the session uses to ask a delegate for a presentation context. | ||
protocol SSOAuthenticationSessionContextProviding { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Others named as Authentification
. Maybe you missed this one. Totally optional.
Co-authored-by: ismailgulek <ismailgulek@users.noreply.github.com>
This is awesome but I fear many people may get confused with the checkbox. I think it would be good to switch to a standard toggle or checkbox UI element: #3913. |
Implement #3846
Requires matrix-org/matrix-ios-kit#757
This PR can be reviewed in this order: