-
Notifications
You must be signed in to change notification settings - Fork 260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Please provide an Element AppImage for Linux #657
Comments
I don't think the core devs have enough bandwidth to monitor all the additional release formats, there was a FlatPak PR from community that has gone stale for this reason too. ++ Why not use the AppImage option inside electron-builder..? |
Also making an arbitrary file from the internet executable and running it sounds like such a great recipe... |
Finally, you should probably specify -web or -electron |
It's would not be "arbitrary" if it came from the original upstream authors and was signed with their key. Linus Torvalds likes the concept btw. |
That's what I suggest. Should be easy to use that. |
Security-wise, there isn't much difference between marking a file downloaded from https://riot.im/... executable and running it, and installing a package downloaded from https://riot.im/.... In fact, running an appimage downloaded from riot.im could be considered less risky, because it only runs under the user's permissions, whereas installing a package can run a script with root privileges. BTW, related to #656 (FlatPak support) |
any updates on this? |
I would appreciate this as well |
I have created a PR for this: element-hq/element-web#6422. |
There is a sandboxing program called firejail that has support for appimages. I already run most applications under this. |
This comment has been minimized.
This comment has been minimized.
Not only are there updates (although I don't like "automatic"), there are even binary delta updates which means you only download the few MB that have actually changed. See AppImageUpdate. |
I would love to see an AppImage asap. Making one is very easy with electron-builder. |
You can drop the .deb package. It's not needed anymore if you provide an AppImage, and an AppImage is easier to build. |
Do AppImages have an update mechanism? If not, then I'd say that the .deb packages are still needed. |
Is anyone working on this? Is there something I can provide to it, or help with, to make it happen? |
@zilti you could try to make some AppImage with electron-builder from the repository, I think it's already using it. We might be able to prepare a PR then. |
Yes, it suffices to change "linux""target" to "appimage" in package.json. Or to add "appImage" to "build", as in "appImage": {
"category": "Network;InstantMessaging;Chat",
"desktop": {
"StartupWMClass": "riot"
}
} and I added |
So it'll take little effort to make some in the CI I guess. I'd really like to use them. I hate chatting in a browser. |
Please let me know if there is an up-to-date usable appImage. Would really appreciate if one is provided officially. |
Any news on this? It's such a small fix... |
This is basically all that is needed: https://github.com/zilti/riot-web.AppImage/blob/master/package.json.patch In that same repo I build the AppImage using CircleCI. It also gets signed with my key. |
Would love to have an appImage for Riot. I use Fedora and would appreciate a desktop app more. |
Thanks to the new, convoluted way to build this I will no longer build an AppImage. I hoped the devs would take this as a starting point to provide their own, but apparently they rather focus on making it more complicated to build from source in the first place (a second repository!), and completely ignore any offered contributions for an AppImage. drops mic |
Its actually simpler, it supports building straight from a riot-web tarball so you no longer have to build the webpack stuff as well as the electron stuff. The additional complexity in the new repository is required for building native code such as Seshat. There's even a docker build image to help. |
There are two steps involved:
Is 1 or 2 what is "convoluted"? Once there are suitable binaries, it should be rather easy to put them into an AppImage. Let me know if I can help. |
@Sarcasm, GitHub automatically expands the
Hmm, yes git describe --tags `git rev-list --tags --max-count=1` The output points to |
i think that the latest release information is stored internally by github (as a reference to a tag), but that you cannot get this information directly from the repository only. this is the documentation on how to get the information (including the tag name) of the latest release: https://docs.github.com/en/rest/reference/repos#get-the-latest-release maybe you can also get the tarball of the latest release instead of using the repository? |
@huguesdk Great! I will do like that then! |
Oh I see, I'm surprised to see stable above the continuous build, but but that Concerning GLIBC, I wouldn't know how to compare either. |
Lol, |
@Sarcasm are you on #element? can you DM me on matrix / IRC? |
Looks good! |
@srevinsaju: great, thanks! i think it would be worth advertising about your appimage on #twim:matrix.org. |
Flatpak, appimage, snap they would be great... 👍 |
An appimage for x86 and and appimage for arm would be awesome! |
The Element Desktop does not include instructions to build ARM builds, although its possible to build a standalone element appimage without its dependencies. Until then, I would not be able to update the Element AppImage continuous builds with ARM builds. x86 looks easy to build, and I can work on it this christmas 😄 |
That is a happy news to know an appimage is on the way for Element. On arm topic... there are several requests about arm packages but none have any success:
|
Yes, agreed. That would solve a lot of issues, even for distro packagers |
OK, then, done. Hopefully it'll help. |
@srevinsaju Thank you for providing an x86 appimage. Awesome! |
Hello, |
@chaperonRose no, the team does not have the resources to maintain a new & unfamiliar to us packaging format. It would increase work significantly and we are a small team. |
Providing an AppImage would have, among others, these advantages:
appimaged
Here is an overview of projects that are already distributing upstream-provided, official AppImages.
Example Riot AppImage:
https://bintray.com/probono/AppImages/Riot/_latestVersion#files
Made using:
https://github.com/AppImage/AppImages/blob/master/recipes/meta/Riot.yml
electron-builder
has native support for generating AppImages, so it should be very easy to do.If you have questions, AppImage developers are on #AppImage on irc.freenode.net.
The text was updated successfully, but these errors were encountered: