Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Join knock rooms on page load if already invited #2355

Merged
merged 1 commit into from
May 3, 2024

Conversation

AndrewFerr
Copy link
Member

When visiting the page for a knock room you are already invited to, join it right away instead of offering to knock (which will fail as long as you remain invited to the room).

When visiting the page for a knock room you are already invited to, join
it right away instead of offering to knock (which will fail as long as
you remain invited to the room).
@AndrewFerr AndrewFerr self-assigned this May 2, 2024
@AndrewFerr AndrewFerr requested a review from a team as a code owner May 2, 2024 18:28
@AndrewFerr
Copy link
Member Author

Issue: when visiting a knock room & auto-joining it, the room header shows the room ID, not the room name. Does this mean a callback is missing somewhere?

@robintown
Copy link
Member

Issue: when visiting a knock room & auto-joining it, the room header shows the room ID, not the room name. Does this mean a callback is missing somewhere?

Don't know about that one… in theory we update the name shown in the UI whenever the room emits a RoomEvent.Name event, so there could be a bug that matrix-js-sdk isn't signaling a name update in this case. Or, it's possible that there are multiple room objects floating around for the same room ID, and one of them is just a placeholder with only the room ID filled in. (that has happened before)

@AndrewFerr AndrewFerr mentioned this pull request May 2, 2024
@AndrewFerr
Copy link
Member Author

Eugh, there's something else funky about this. Despite joining the room, a joined user forever sees "Waiting for other participants…" even if other users have joined the call.

Putting this in draft until that's solved.

@AndrewFerr AndrewFerr marked this pull request as draft May 2, 2024 18:43
@AndrewFerr AndrewFerr marked this pull request as ready for review May 3, 2024 16:32
@AndrewFerr
Copy link
Member Author

I did the sensible thing of testing the Netlify build of this instead of my local setup, and can reproduce not hitting the problem of a missing room name & getting stuck waiting for other call members.

At this point I'm inclined to believe those issues are unrelated to this PR, especially given how simple this PR is. So, I shall merge this.

@AndrewFerr AndrewFerr merged commit 56312b2 into livekit May 3, 2024
3 checks passed
@AndrewFerr AndrewFerr deleted the af/join-invited-room-on-visit branch May 3, 2024 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants