Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: migrate master main #2946

Merged
merged 3 commits into from
Oct 11, 2022
Merged

chore: migrate master main #2946

merged 3 commits into from
Oct 11, 2022

Conversation

georgexu99
Copy link
Contributor

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes are appropriately documented (if applicable).
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:

@georgexu99 georgexu99 changed the title Gxu migrate master main Chore: migrate master main Oct 6, 2022
@georgexu99 georgexu99 changed the title Chore: migrate master main chore: migrate master main Oct 6, 2022
@@ -8,7 +8,7 @@ cache:
- node_modules
branches:
only:
- master
- main
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bringing over a comment from @malept in a previous PR - we should probably just delete this file before stable release. For the purposes of this PR, we can leave the change in, but we should open a separate PR removing the file and other unused template files.

@georgexu99 georgexu99 marked this pull request as ready for review October 6, 2022 22:12
@codecov
Copy link

codecov bot commented Oct 6, 2022

Codecov Report

Merging #2946 (e84d7ba) into master (1cd68e3) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2946   +/-   ##
=======================================
  Coverage   71.33%   71.33%           
=======================================
  Files          79       79           
  Lines        2414     2414           
  Branches      452      452           
=======================================
  Hits         1722     1722           
  Misses        469      469           
  Partials      223      223           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1cd68e3...e84d7ba. Read the comment docs.

CONTRIBUTING.md Outdated Show resolved Hide resolved
@VerteDinde VerteDinde merged commit d28974e into master Oct 11, 2022
@VerteDinde VerteDinde deleted the gxu-migrate-master-main branch October 11, 2022 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants