test: fix flaky contentTracing.startRecording spec #31409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zcbenz
changed the title
zcbenz
force-pushed
the
content-tracing-why-fails
branch
from
138d7f0
to
9b25e73
Compare
jkleinsc
approved these changes
Oct 13, 2021
|
Merging as CI failure is known flake unrelated to this PR. |
|
No Release Notes |
|
I have automatically backported this PR to "16-x-y", please check out #31411 |
5 tasks
t57ser
pushed a commit
to t57ser/electron
that referenced
this pull request
Oct 27, 2021
t57ser
pushed a commit
to t57ser/electron
that referenced
this pull request
Oct 27, 2021
t57ser
pushed a commit
to t57ser/electron
that referenced
this pull request
Oct 29, 2021
t57ser
pushed a commit
to t57ser/electron
that referenced
this pull request
Oct 29, 2021
t57ser
pushed a commit
to t57ser/electron
that referenced
this pull request
Oct 29, 2021
t57ser
pushed a commit
to t57ser/electron
that referenced
this pull request
Oct 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Checking file size is not a reliable way to test
contentTracing.startRecording({excluded_categories}), since there might still be lots of events in the meta category.This PR changes the test to check the occurrence of certain events instead.
Release Notes
Notes: none